From: eileen <emcnaughton@wikimedia.org>
Date: Tue, 15 Dec 2020 02:25:56 +0000 (+1300)
Subject: Remove always true parameter
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=82c4e0051778713d83ebcd634a51e03aeea87e1a;p=civicrm-core.git

Remove always true parameter
---

diff --git a/CRM/Member/Form/Membership.php b/CRM/Member/Form/Membership.php
index caa74005d9..5c1e1e6a1d 100644
--- a/CRM/Member/Form/Membership.php
+++ b/CRM/Member/Form/Membership.php
@@ -1325,8 +1325,7 @@ DESC limit 1");
           ],
           $financialType,
           FALSE,
-          $this->_bltID,
-          TRUE
+          $this->_bltID
         );
 
         //create new soft-credit record, CRM-13981
@@ -1877,8 +1876,6 @@ DESC limit 1");
    *
    * @param int $billingLocationID
    *   ID of billing location type.
-   * @param bool $isRecur
-   *   Is this recurring?
    *
    * @return \CRM_Contribute_DAO_Contribution
    *
@@ -1892,8 +1889,7 @@ DESC limit 1");
     $contributionParams,
     $financialType,
     $online,
-    $billingLocationID,
-    $isRecur
+    $billingLocationID
   ) {
     $transaction = new CRM_Core_Transaction();
     $contactID = $contributionParams['contact_id'];
@@ -1914,7 +1910,7 @@ DESC limit 1");
     if (!isset($params['is_email_receipt']) && $isEmailReceipt) {
       $params['is_email_receipt'] = $isEmailReceipt;
     }
-    $params['is_recur'] = $isRecur;
+    $params['is_recur'] = TRUE;
     $params['payment_instrument_id'] = $contributionParams['payment_instrument_id'] ?? NULL;
     $recurringContributionID = CRM_Contribute_Form_Contribution_Confirm::processRecurringContribution($form, $params, $contactID, $financialType);