From: eileenmcnaugton <eileen@fuzion.co.nz>
Date: Fri, 16 Oct 2015 03:04:41 +0000 (+1300)
Subject: CRM-17411 fix strict warning by removing empty override function
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=7d73813f3b9360231a69b464ae904d263ef974d4;p=civicrm-core.git

CRM-17411 fix strict warning by removing empty override function
---

diff --git a/CRM/Report/Form/Membership/Summary.php b/CRM/Report/Form/Membership/Summary.php
index e9e5f038d5..402c0b8a71 100644
--- a/CRM/Report/Form/Membership/Summary.php
+++ b/CRM/Report/Form/Membership/Summary.php
@@ -29,7 +29,6 @@
  *
  * @package CRM
  * @copyright CiviCRM LLC (c) 2004-2015
- * $Id$
  */
 class CRM_Report_Form_Membership_Summary extends CRM_Report_Form {
 
@@ -145,16 +144,6 @@ class CRM_Report_Form_Membership_Summary extends CRM_Report_Form {
     parent::preProcess();
   }
 
-  /**
-   * Set default values.
-   *
-   * @return array
-   *   Default values.
-   */
-  public function setDefaultValues() {
-    return parent::setDefaultValues();
-  }
-
   /**
    * Generate select clause.
    */
@@ -186,22 +175,8 @@ class CRM_Report_Form_Membership_Summary extends CRM_Report_Form {
   }
 
   /**
-   * Set form rules.
-   *
-   * @param $fields
-   * @param $files
-   * @param $self
-   *
-   * @return array
+   * Generate from clause.
    */
-  public static function formRule($fields, $files, $self) {
-    $errors = $grouping = array();
-    //check for searching combination of dispaly columns and
-    //grouping criteria
-
-    return $errors;
-  }
-
   public function from() {
     $this->_from = NULL;
 
@@ -225,6 +200,11 @@ LEFT  JOIN civicrm_contribution  {$this->_aliases['civicrm_contribution']}
     }
   }
 
+  /**
+   * Generate where clause.
+   *
+   * @todo this looks like it duplicates the parent & could go.
+   */
   public function where() {
     $clauses = array();
     foreach ($this->_columns as $tableName => $table) {
@@ -283,6 +263,11 @@ LEFT  JOIN civicrm_contribution  {$this->_aliases['civicrm_contribution']}
     return $statistics;
   }
 
+  /**
+   * Generate group by clause.
+   *
+   * @todo looks like a broken duplicate of the parent.
+   */
   public function groupBy() {
     $this->_groupBy = "";
     if (is_array($this->_params['group_bys']) &&
@@ -311,6 +296,9 @@ LEFT  JOIN civicrm_contribution  {$this->_aliases['civicrm_contribution']}
     }
   }
 
+  /**
+   * PostProcess function.
+   */
   public function postProcess() {
     $this->_params = $this->controller->exportValues($this->_name);
     if (empty($this->_params) &&