From: Tim Otten <totten@civicrm.org>
Date: Fri, 4 Apr 2014 07:39:03 +0000 (-0700)
Subject: CRM-14423 - CiviUnitTestCase - Only run env checks, not security checks, during unit... 
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=7c42ee3303aa11c977c0b2732f447bb25fd9dc93;p=civicrm-core.git

CRM-14423 - CiviUnitTestCase - Only run env checks, not security checks, during unit-tests.

The security checks are more I/O intensive.
---

diff --git a/CRM/Utils/Check.php b/CRM/Utils/Check.php
index 9b13b0db7a..288a78f0e9 100644
--- a/CRM/Utils/Check.php
+++ b/CRM/Utils/Check.php
@@ -60,8 +60,10 @@ class CRM_Utils_Check {
 
   /**
    * Execute "checkAll"
+   *
+   * @param array|NULL $messages list of CRM_Utils_Check_Message; or NULL if the default list should be fetched
    */
-  public function showPeriodicAlerts() {
+  public function showPeriodicAlerts($messages = NULL) {
     if (CRM_Core_Permission::check('administer CiviCRM')
       && CRM_Core_BAO_Setting::getItem(CRM_Core_BAO_Setting::SYSTEM_PREFERENCES_NAME, 'securityAlert', NULL, TRUE)
     ) {
@@ -72,7 +74,10 @@ class CRM_Utils_Check {
         $config = CRM_Core_Config::singleton();
         $config->cleanup(0, FALSE);
 
-        foreach ($this->checkAll() as $message) {
+        if ($messages === NULL) {
+          $messages = $this->checkAll();
+        }
+        foreach ($messages as $message) {
           CRM_Core_Session::setStatus($message->getMessage(), $message->getTitle());
         }
       }
@@ -81,9 +86,13 @@ class CRM_Utils_Check {
 
   /**
    * Throw an exception if any of the checks fail
+   *
+   * @param array|NULL $messages list of CRM_Utils_Check_Message; or NULL if the default list should be fetched
    */
-  public function assertValid() {
-    $messages = $this->checkAll();
+  public function assertValid($messages = NULL) {
+    if ($messages === NULL) {
+      $messages = $this->checkAll();
+    }
     if (!empty($messages)) {
       $messagesAsArray = array();
       foreach ($messages as $message) {
diff --git a/tests/phpunit/CiviTest/CiviUnitTestCase.php b/tests/phpunit/CiviTest/CiviUnitTestCase.php
index 118fde48ce..bbbd598235 100644
--- a/tests/phpunit/CiviTest/CiviUnitTestCase.php
+++ b/tests/phpunit/CiviTest/CiviUnitTestCase.php
@@ -307,7 +307,8 @@ class CiviUnitTestCase extends PHPUnit_Extensions_Database_TestCase {
     // also set this global hack
     $GLOBALS['_PEAR_ERRORSTACK_OVERRIDE_CALLBACK'] = array();
 
-    CRM_Utils_Check::singleton()->assertValid();
+    $env = new CRM_Utils_Check_Env();
+    CRM_Utils_Check::singleton()->assertValid($env->checkAll());
   }
 
   /**