From: Eileen McNaughton <eileen@fuzion.co.nz>
Date: Mon, 16 Mar 2015 08:38:56 +0000 (+1300)
Subject: make mailing failure tests less specific. We try not to make failure tests too specif... 
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=7bd9cc5f02d483260e675ba5577a69065395e436;p=civicrm-core.git

make mailing failure tests less specific. We try not to make failure tests too specific, in this case adding 'type'
to spec will change the message & we may as well not check it rather than changing the test
---

diff --git a/tests/phpunit/api/v3/MailingGroupTest.php b/tests/phpunit/api/v3/MailingGroupTest.php
index d076c0bcca..a4a3169c3e 100644
--- a/tests/phpunit/api/v3/MailingGroupTest.php
+++ b/tests/phpunit/api/v3/MailingGroupTest.php
@@ -58,13 +58,7 @@ class api_v3_MailingGroupTest extends CiviUnitTestCase {
       'time_stamp' => '20111111010101',
       'hash' => 'sasa',
     );
-    $result = $this->callAPIFailure('mailing_event_subscribe', 'create', $params);
-    if ($result['error_message'] != 'Subscription failed') {
-      $this->assertEquals($result['error_message'], 'Invalid Group id', 'In line ' . __LINE__);
-    }
-    else {
-      $this->assertEquals($result['error_message'], 'Subscription failed', 'In line ' . __LINE__);
-    }
+    $this->callAPIFailure('mailing_event_subscribe', 'create', $params);
   }
 
   /**
@@ -105,8 +99,7 @@ class api_v3_MailingGroupTest extends CiviUnitTestCase {
       'time_stamp' => '20101212121212',
     );
 
-    $result = $this->callAPIFailure('mailing_event_unsubscribe', 'create', $params);
-    $this->assertEquals($result['error_message'], 'Queue event could not be found', 'In line ' . __LINE__);
+    $this->callAPIFailure('mailing_event_unsubscribe', 'create', $params);
   }
 
   //--------- civicrm_mailing_group_event_domain_unsubscribe methods -------
@@ -123,8 +116,7 @@ class api_v3_MailingGroupTest extends CiviUnitTestCase {
       'time_stamp' => '20101212121212',
     );
 
-    $result = $this->callAPIFailure('mailing_event_unsubscribe', 'create', $params);
-    $this->assertEquals($result['error_message'], 'Domain Queue event could not be found', 'In line ' . __LINE__);
+    $this->callAPIFailure('mailing_event_unsubscribe', 'create', $params);
   }
 
   //----------- civicrm_mailing_group_event_resubscribe methods--------
@@ -144,8 +136,7 @@ class api_v3_MailingGroupTest extends CiviUnitTestCase {
       'org_unsubscribe' => 'test',
       'time_stamp' => '20101212121212',
     );
-    $result = $this->callAPIFailure('mailing_event_resubscribe', 'create', $params);
-    $this->assertEquals($result['error_message'], 'Queue event could not be found', 'In line ' . __LINE__);
+    $this->callAPIFailure('mailing_event_resubscribe', 'create', $params);
   }
 
   //------------------------ success case ---------------------