From: Eileen McNaughton <emcnaughton@wikimedia.org>
Date: Fri, 22 Sep 2023 04:03:57 +0000 (+1200)
Subject: Remove unreachable code
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=780ffbb6586b29c79661875cf2b7528621770639;p=civicrm-core.git

Remove unreachable code

The ContributionRecur::add function throws an error if there
is a problem - it doesn't return an error
---

diff --git a/CRM/Contribute/Form/Contribution/Confirm.php b/CRM/Contribute/Form/Contribution/Confirm.php
index e43d107f1c..cfb4635f6e 100644
--- a/CRM/Contribute/Form/Contribution/Confirm.php
+++ b/CRM/Contribute/Form/Contribution/Confirm.php
@@ -1217,19 +1217,6 @@ class CRM_Contribute_Form_Contribution_Confirm extends CRM_Contribute_Form_Contr
     $campaignId = $params['campaign_id'] ?? $form->_values['campaign_id'] ?? NULL;
     $recurParams['campaign_id'] = $campaignId;
     $recurring = CRM_Contribute_BAO_ContributionRecur::add($recurParams);
-    if (is_a($recurring, 'CRM_Core_Error')) {
-      CRM_Core_Error::displaySessionError($recurring);
-      $urlString = 'civicrm/contribute/transact';
-      $urlParams = '_qf_Main_display=true';
-      if (get_class($form) == 'CRM_Contribute_Form_Contribution') {
-        $urlString = 'civicrm/contact/view/contribution';
-        $urlParams = "action=add&cid={$form->_contactID}";
-        if ($form->_mode) {
-          $urlParams .= "&mode={$form->_mode}";
-        }
-      }
-      CRM_Utils_System::redirect(CRM_Utils_System::url($urlString, $urlParams));
-    }
     $form->_params['contributionRecurID'] = $recurring->id;
 
     return $recurring->id;