From: Dave Greenberg <dave@civicrm.org>
Date: Tue, 10 Jun 2014 20:51:00 +0000 (-0700)
Subject: CRM-14837 - Fix CiviMember Component Preferences form.
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=743c2a93a067ee7dbb2f4f1a7a40b8bdbcf71daf;p=civicrm-core.git

CRM-14837 - Fix CiviMember Component Preferences form.

----------------------------------------
* CRM-14837:
  https://issues.civicrm.org/jira/browse/CRM-14837
---

diff --git a/CRM/Admin/Form/Preferences/Member.php b/CRM/Admin/Form/Preferences/Member.php
index 7ba41a5793..74e4688e49 100644
--- a/CRM/Admin/Form/Preferences/Member.php
+++ b/CRM/Admin/Form/Preferences/Member.php
@@ -46,6 +46,7 @@ class CRM_Admin_Form_Preferences_Member extends CRM_Admin_Form_Preferences {
         'default_renewal_contribution_page' => array(
           'html_type' => 'select',
           'title' => ts('Default online membership renewal page'),
+          'option_values' => array('' => ts('- select -')) + CRM_Contribute_PseudoConstant::contributionPage(),
           'weight' => 1,
           'description' => ts('If you select a default online contribution page for self-service membership renewals, a "renew" link pointing to that page will be displayed on the Contact Dashboard for memberships which were entered offline. You will need to ensure that the membership block for the selected online contribution page includes any currently available memberships.'),
         ),
@@ -62,14 +63,6 @@ class CRM_Admin_Form_Preferences_Member extends CRM_Admin_Form_Preferences {
    * @access public
    */
   function buildQuickForm() {
-
-    $this->add('select', 'default_renewal_contribution_page',
-      ts('Default Online Membership Renewal Page'),
-      array(
-        '' => ts('- select -')) +
-      CRM_Contribute_PseudoConstant::contributionPage()
-    );
-
     parent::buildQuickForm();
   }
 }