From: Jay Pfaffman <jay@literatecomputing.com>
Date: Tue, 4 Aug 2020 22:47:30 +0000 (-0700)
Subject: FIX: discourse-doctor plugin check too loose (#478)
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=6ffca0c20382af66c8845d93eb041c5ec3799470;p=discourse_docker.git

FIX: discourse-doctor plugin check too loose (#478)

The non-official plugin check was looking only for `git`, which would match other things in the yml file (e.g., a digital ocean S3 bucket name).

`grep` for `'git clone'` should solve that problem.

Though I did test this edit on a running sitee, I made these edit in the web interface by hand rather than pushing a commit where I tested it. Please look twice to make sure that I didn't do something silly when making the edit here.
---

diff --git a/discourse-doctor b/discourse-doctor
index 67c4739..4d66900 100755
--- a/discourse-doctor
+++ b/discourse-doctor
@@ -185,7 +185,7 @@ get_discourse_config() {
 
 check_plugins() {
   log -e "\n\n==================== PLUGINS ===================="
-  log -e "$(grep git containers/$app_name.yml)"
+  log -e "$(grep 'git clone' containers/$app_name.yml)"
   grep git containers/$app_name.yml > /tmp/$PPID.grep
 
   if grep -cv "github.com/discourse" /tmp/$PPID.grep > /dev/null