From: eileen <emcnaughton@wikimedia.org>
Date: Tue, 10 Jan 2017 01:54:13 +0000 (+1300)
Subject: Clarify return val, fix casing on a couple of function calls
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=6ea16bbfd670e92967c519e69f2e16350bf29b57;p=civicrm-core.git

Clarify return val, fix casing on a couple of function calls
---

diff --git a/CRM/ACL/Form/WordPress/Permissions.php b/CRM/ACL/Form/WordPress/Permissions.php
index ff4617ba5e..5273969e0a 100644
--- a/CRM/ACL/Form/WordPress/Permissions.php
+++ b/CRM/ACL/Form/WordPress/Permissions.php
@@ -134,7 +134,7 @@ class CRM_ACL_Form_WordPress_Permissions extends CRM_Core_Form {
         // Get the permissions into a format that matches what we get from WP
         $allWarningPermissions = CRM_Core_Permission::getAnonymousPermissionsWarnings();
         foreach ($allWarningPermissions as $key => $permission) {
-          $allWarningPermissions[$key] = CRM_utils_String::munge(strtolower($permission));
+          $allWarningPermissions[$key] = CRM_Utils_String::munge(strtolower($permission));
         }
         $warningPermissions = array_intersect($allWarningPermissions, array_keys($rolePermissions));
         $warningPermissionNames = array();
diff --git a/CRM/Case/Form/Activity.php b/CRM/Case/Form/Activity.php
index 7156acd1fb..338cd36457 100644
--- a/CRM/Case/Form/Activity.php
+++ b/CRM/Case/Form/Activity.php
@@ -341,7 +341,7 @@ class CRM_Case_Form_Activity extends CRM_Activity_Form_Activity {
       return TRUE;
     }
 
-    return parent::formrule($fields, $files, $self);
+    return parent::formRule($fields, $files, $self);
   }
 
   /**
diff --git a/CRM/Case/Form/Task/Print.php b/CRM/Case/Form/Task/Print.php
index e9ce32a15b..5e17d3fe2c 100644
--- a/CRM/Case/Form/Task/Print.php
+++ b/CRM/Case/Form/Task/Print.php
@@ -41,7 +41,7 @@ class CRM_Case_Form_Task_Print extends CRM_Case_Form_Task {
    * Build all the data structures needed to build the form.
    */
   public function preProcess() {
-    parent::preprocess();
+    parent::preProcess();
 
     // set print view, so that print templates are called
     $this->controller->setPrint(1);
diff --git a/CRM/Core/Payment/AuthorizeNet.php b/CRM/Core/Payment/AuthorizeNet.php
index f365683550..2dd73da5f8 100644
--- a/CRM/Core/Payment/AuthorizeNet.php
+++ b/CRM/Core/Payment/AuthorizeNet.php
@@ -816,7 +816,7 @@ class CRM_Core_Payment_AuthorizeNet extends CRM_Core_Payment {
 
     curl_close($submit);
 
-    $responseFields = $this->_ParseArbReturn($response);
+    $responseFields = $this->_parseArbReturn($response);
     $message = "{$responseFields['code']}: {$responseFields['text']}";
 
     if ($responseFields['resultCode'] == 'Error') {
diff --git a/CRM/Event/Cart/Form/Checkout/Payment.php b/CRM/Event/Cart/Form/Checkout/Payment.php
index cdef3ae592..59f843ad46 100644
--- a/CRM/Event/Cart/Form/Checkout/Payment.php
+++ b/CRM/Event/Cart/Form/Checkout/Payment.php
@@ -780,7 +780,7 @@ class CRM_Event_Cart_Form_Checkout_Payment extends CRM_Event_Cart_Form_Cart {
     $dao = CRM_Core_DAO::executeQuery($sql, '');
     while ($dao->fetch()) {
       if ($dao->is_active != '1') {
-        return;
+        return FALSE;
       }
     }
     $discounted_priceset_ids = _cividiscount_get_discounted_priceset_ids();