From: Alon Levy <alon@pobox.com>
Date: Fri, 27 Dec 2013 00:34:40 +0000 (-0600)
Subject: pdf/processing: avoid possible dead goblin if pdfinfo failed
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=690f50de1c0f56dd49558c38de8aac213a658672;p=mediagoblin.git

pdf/processing: avoid possible dead goblin if pdfinfo failed
---

diff --git a/mediagoblin/media_types/pdf/processing.py b/mediagoblin/media_types/pdf/processing.py
index 6fb0b782..4dd894d8 100644
--- a/mediagoblin/media_types/pdf/processing.py
+++ b/mediagoblin/media_types/pdf/processing.py
@@ -210,6 +210,11 @@ def pdf_info(original):
     info_dict = dict([[part.strip() for part in l.strip().split(':', 1)]
                       for l in lines if ':' in l])
 
+    if 'Page size' not in info_dict.keys():
+        # TODO - message is for the user, not debug, but BadMediaFail not taking an argument, fix that.
+        _log.debug('Missing "Page size" key in returned pdf - conversion failed?')
+        raise BadMediaFail()
+
     for date_key in [('pdf_mod_date', 'ModDate'),
                      ('pdf_creation_date', 'CreationDate')]:
         if date_key in info_dict: