From: Donald A. Lobo <lobo@civicrm.org>
Date: Wed, 29 Jan 2014 22:11:24 +0000 (-0800)
Subject: CRM-14085 - wrong syntax on inner join for contribution report
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=65fd91eada52109bd7c387111dd0bcc2fed996c0;p=civicrm-core.git

CRM-14085 - wrong syntax on inner join for contribution report

http://issues.civicrm.org/jira/browse/CRM-14085
---

diff --git a/CRM/Report/Form/Member/ContributionDetail.php b/CRM/Report/Form/Member/ContributionDetail.php
index 442c6f856c..e3aefcf087 100644
--- a/CRM/Report/Form/Member/ContributionDetail.php
+++ b/CRM/Report/Form/Member/ContributionDetail.php
@@ -631,11 +631,12 @@ class CRM_Report_Form_Member_ContributionDetail extends CRM_Report_Form {
           INSERT INTO civireport_membership_contribution_detail (contribution_id, contact_id, membership_id)
           SELECT contribution.id, contact.id, m.id
           FROM civicrm_contribution contribution
-          INNER JOIN civicrm_contact contact {$this->_aclFrom}
+          INNER JOIN civicrm_contact contact
                 ON contact.id = contribution.contact_id AND contribution.is_test = 0
-           LEFT JOIN civicrm_membership_payment mp
+          {$this->_aclFrom}
+          LEFT JOIN civicrm_membership_payment mp
                 ON contribution.id = mp.contribution_id
-           LEFT JOIN civicrm_membership m
+          LEFT JOIN civicrm_membership m
                 ON mp.membership_id = m.id AND m.is_test = 0 ";
 
     CRM_Core_DAO::executeQuery($fillTemp);