From: Eileen McNaughton <emcnaughton@wikimedia.org>
Date: Sat, 23 Oct 2021 04:43:59 +0000 (+1300)
Subject: [Ref] Make functions private to protect them
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=62e0c841d825b8fd63506b25b42170d28475399b;p=civicrm-core.git

[Ref] Make functions private to protect them

As we move functions to this class making them private once they are unused outside the class
makes it easier to clean them up
---

diff --git a/CRM/Contribute/BAO/FinancialProcessor.php b/CRM/Contribute/BAO/FinancialProcessor.php
index e9c28ef83e..ef50f69dd6 100644
--- a/CRM/Contribute/BAO/FinancialProcessor.php
+++ b/CRM/Contribute/BAO/FinancialProcessor.php
@@ -67,7 +67,7 @@ class CRM_Contribute_BAO_FinancialProcessor {
    *
    * @return array
    */
-  public static function createFinancialItemsForLine($params, $context, $fields, array $previousLineItems, array $inputParams, bool $isARefund, $trxnIds, $fieldId): array {
+  private static function createFinancialItemsForLine($params, $context, $fields, array $previousLineItems, array $inputParams, bool $isARefund, $trxnIds, $fieldId): array {
     foreach ($fields as $fieldValueId => $lineItemDetails) {
       $prevFinancialItem = CRM_Financial_BAO_FinancialItem::getPreviousFinancialItem($lineItemDetails['id']);
       $receiveDate = CRM_Utils_Date::isoToMysql($params['prevContribution']->receive_date);
@@ -133,7 +133,7 @@ class CRM_Contribute_BAO_FinancialProcessor {
    *
    * @return int
    */
-  public static function getMultiplier($contribution_status_id, $context) {
+  private static function getMultiplier($contribution_status_id, $context) {
     if ($context === 'changeFinancialType' || CRM_Contribute_BAO_Contribution::isContributionStatusNegative($contribution_status_id)) {
       return -1;
     }