From: Alice Frumin Date: Mon, 10 Jun 2019 19:01:46 +0000 (-0400) Subject: organizing by git lab issue and condensing as well as pulling out obvious misc X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=5c43d846eb8b16dde39ab863bddaa818efdc75d2;p=civicrm-core.git organizing by git lab issue and condensing as well as pulling out obvious misc --- diff --git a/release-notes/5.15.0.md b/release-notes/5.15.0.md index 440f43429a..778ea1c92c 100644 --- a/release-notes/5.15.0.md +++ b/release-notes/5.15.0.md @@ -33,405 +33,421 @@ Released July 3, 2019 ### Core CiviCRM -- **Add CRM_Utils_System::sendResponse(). Fix AssetBuilder's status-code on WP. ([14468](https://github.com/civicrm/civicrm-core/pull/14468))** - -- **[NFC] Update Exception DAO class ([14482](https://github.com/civicrm/civicrm-core/pull/14482))** - -- **[nfc] [test] Skip testGetFromTo on date transition ([14472](https://github.com/civicrm/civicrm-core/pull/14472))** +- **dev/joomla#11 Fix php warning when viewing profiles ([14312](https://github.com/civicrm/civicrm-core/pull/14312))** -- **[NFC][test-fix] centralise use of assertLike for comparing sql ([14470](https://github.com/civicrm/civicrm-core/pull/14470))** +- **dev/drupal#19 Drupal8: fix bootstrap when used by the REST API ([14302](https://github.com/civicrm/civicrm-core/pull/14302) and [12152](https://github.com/civicrm/civicrm-core/pull/12152))** -- **Fix Exception api to save lower id number as contact 1 ([14448](https://github.com/civicrm/civicrm-core/pull/14448))** +- **dev/financial#54 Fix mishandling of deferred revenue settings ([14267](https://github.com/civicrm/civicrm-core/pull/14267))** -- **dev/core#1025 fix unreleased regression on contact.get with custom fields ([14473](https://github.com/civicrm/civicrm-core/pull/14473))** +- **dev/financial#56 Fix inappropriate sales tax row addition ([14309](https://github.com/civicrm/civicrm-core/pull/14309))** -- **Fix Exception to remove result from duplicates ([14447](https://github.com/civicrm/civicrm-core/pull/14447))** +- **dev/financial#59 Fix unreleased regression on batch form ([14377](https://github.com/civicrm/civicrm-core/pull/14377))** -- **Permit sort_name as a url parameter on advanced search ([14475](https://github.com/civicrm/civicrm-core/pull/14475))** +- **dev/translation#26 Fix Notice errors caused by l10n rewriting of quer… ([14152](https://github.com/civicrm/civicrm-core/pull/14152))** -- **[REF] Move retrieval of basicSearchFields to 'get' fn ([14476](https://github.com/civicrm/civicrm-core/pull/14476))** +- **dev/core#369 Prevent hard fail of API Job when SMS provider has been deleted ([14266](https://github.com/civicrm/civicrm-core/pull/14266))** -- **Fix version for pledge message update, also remove 'please print' ([14469](https://github.com/civicrm/civicrm-core/pull/14469))** +- **dev/core#389 [preliminary cleanup+ test] Standardise metadat for custom field ([14401](https://github.com/civicrm/civicrm-core/pull/14401) and [14386](https://github.com/civicrm/civicrm-core/pull/14386))** -- **Wrap titles in metadata in ts on payment.create api ([14450](https://github.com/civicrm/civicrm-core/pull/14450))** +- **dev/core#562 [cleanup] remove some more instances of ->free() ([14179](https://github.com/civicrm/civicrm-core/pull/14179))** -- **[Outbound mail admin form] fix some more notices resulting from recent change ([14433](https://github.com/civicrm/civicrm-core/pull/14433))** +- **dev/core#627 Extend a unit test to verify fix made by Sunil ([14350](https://github.com/civicrm/civicrm-core/pull/14350))** -- **Fix upgrade on participant_register date ([14427](https://github.com/civicrm/civicrm-core/pull/14427))** +- **dev/core#628 - Make Quicksearch options sortable ([14441](https://github.com/civicrm/civicrm-core/pull/14441))** -- **Misc translation 'ts' fixes ([14467](https://github.com/civicrm/civicrm-core/pull/14467))** +- **(dev/core#705) Disabling Alphabetical Pager is not respected for events ([14203](https://github.com/civicrm/civicrm-core/pull/14203))** -- **dev/core#1010 pledge_acknowledge template - capitalization and greeting ([14465](https://github.com/civicrm/civicrm-core/pull/14465))** +- **dev/core#723 Fix fatal error when trying to merge contacts with a cus… ([14325](https://github.com/civicrm/civicrm-core/pull/14325))** -- **Conditionally use Drupal's jQuery only if available ([14442](https://github.com/civicrm/civicrm-core/pull/14442))** +- **dev/core/issues/743, Donot join relationship table when not required ([14082](https://github.com/civicrm/civicrm-core/pull/14082))** -- **Don't run search when editing smartgroup criteria ([14464](https://github.com/civicrm/civicrm-core/pull/14464))** +- **dev/Core#785: Extend addField to support select2 widget ([14416](https://github.com/civicrm/civicrm-core/pull/14416))** -- **5.14 ([14463](https://github.com/civicrm/civicrm-core/pull/14463))** +- **dev/core#830 Expose cancel_reason field by cleaning up the cancel template to use entity field template ([13997](https://github.com/civicrm/civicrm-core/pull/13997))** -- **Add Contact.get_merge_conflicts api ([14394](https://github.com/civicrm/civicrm-core/pull/14394))** +- **dev/core#879 SMTP help text is misleading - references the wrong admin screen ([14329](https://github.com/civicrm/civicrm-core/pull/14329))** -- **[NFC] array formatting in api_v3_paymentTest class ([14451](https://github.com/civicrm/civicrm-core/pull/14451))** +- **dev/core#888 - Backoffice participant transfer form does not populate… ([14102](https://github.com/civicrm/civicrm-core/pull/14102))** -- **Test tweaks that *might* help with intermittant test weirdness ([14458](https://github.com/civicrm/civicrm-core/pull/14458))** +- **dev/core#896 - fix notice warning on closing a case ([14160](https://github.com/civicrm/civicrm-core/pull/14160))** -- **dev/core#1023 - E_NOTICE when creating bulk SMS ([14449](https://github.com/civicrm/civicrm-core/pull/14449))** +- **dev/core#898: use user.login route for D8 login URL instead of user.page ([14138](https://github.com/civicrm/civicrm-core/pull/14138))** -- **5.14 ([14457](https://github.com/civicrm/civicrm-core/pull/14457))** +- **dev/core#905 Add contribution recur statuses 'Processing' and 'Failing' ([14395](https://github.com/civicrm/civicrm-core/pull/14395))** -- **dev/core#1022 - Manage Case deleted activities search filter no longer working ([14445](https://github.com/civicrm/civicrm-core/pull/14445))** +- **dev/core#905 Separate contribution_recur status_id option group from contribution option group ([14343](https://github.com/civicrm/civicrm-core/pull/14343))** -- **5.14 to master ([14455](https://github.com/civicrm/civicrm-core/pull/14455))** +- **dev/core#913 - update autogenerated .htaccess for apache 2.4 ([14158](https://github.com/civicrm/civicrm-core/pull/14158))** -- **(NFC) Remove without param tests ([14454](https://github.com/civicrm/civicrm-core/pull/14454))** +- **dev/core#926 [ref] adds a test & does a preliminary extraction ([14181](https://github.com/civicrm/civicrm-core/pull/14181))** -- **dev/core#628 - Make Quicksearch options sortable ([14441](https://github.com/civicrm/civicrm-core/pull/14441))** +- **dev/core#927 [ref] Extract contribution.cancel function ([14197](https://github.com/civicrm/civicrm-core/pull/14197))** -- **Add api for Dedupe.getduplicates ([14411](https://github.com/civicrm/civicrm-core/pull/14411))** +- **dev/core#932 Fix dedupe contacts flip selection ([14195](https://github.com/civicrm/civicrm-core/pull/14195))** -- **Avoid logging error message if status check query fails. ([14363](https://github.com/civicrm/civicrm-core/pull/14363))** +- **dev/core#945 - fix use of $this error in static method ([14217](https://github.com/civicrm/civicrm-core/pull/14217))** -- **dev/core#1014 fix e-notice regression ([14426](https://github.com/civicrm/civicrm-core/pull/14426))** +- **dev/core#953 Add test for updating email via import & ensuring it is primary ([14225](https://github.com/civicrm/civicrm-core/pull/14225))** -- **Change Activity tag to use select2 ([14247](https://github.com/civicrm/civicrm-core/pull/14247))** +- **dev/core#964 Add start date and end date values on page contribution widget ajax response ([14262](https://github.com/civicrm/civicrm-core/pull/14262))** -- **[REF] Activity form - very minor tidy up ([14434](https://github.com/civicrm/civicrm-core/pull/14434))** +- **dev/core/966 skip urlencode for email in elavon xml ([14263](https://github.com/civicrm/civicrm-core/pull/14263))** -- **5.14 to master ([14432](https://github.com/civicrm/civicrm-core/pull/14432))** +- **(dev/core#959) Expose contribution page in Contribution Summary report ([14249](https://github.com/civicrm/civicrm-core/pull/14249))** -- **Fix running of CRM_Utils_MoneyTest on PHPUnit6+ ([14424](https://github.com/civicrm/civicrm-core/pull/14424))** +- **dev/core#980 [phpunit test] update phpunit extends class to support later versions ([14333](https://github.com/civicrm/civicrm-core/pull/14333), [14279](https://github.com/civicrm/civicrm-core/pull/14279), [14283](https://github.com/civicrm/civicrm-core/pull/14283) and [14321](https://github.com/civicrm/civicrm-core/pull/14321))** -- **Improve formatting for settings checkboxes ([14419](https://github.com/civicrm/civicrm-core/pull/14419))** +- **dev/core#981 Sorting participants ignored search values. ([14313](https://github.com/civicrm/civicrm-core/pull/14313))** -- **Caches - Normalize dependency on php-cache integration-tests ([14423](https://github.com/civicrm/civicrm-core/pull/14423))** +- **dev/core#982 add dedupe.getstatistics api ([14298](https://github.com/civicrm/civicrm-core/pull/14298))** -- **phpunit6 - Implement TAP printer ([14421](https://github.com/civicrm/civicrm-core/pull/14421))** +- **dev/core#985 Fix trailing slash for urls on Windows ([14405](https://github.com/civicrm/civicrm-core/pull/14405))** -- **5.14 to master ([14422](https://github.com/civicrm/civicrm-core/pull/14422))** +- **dev/core#994 remove Thousands Separator can not have more than 1 character rule ([14376](https://github.com/civicrm/civicrm-core/pull/14376))** -- **Try running unit tests on phpunit6 ([14404](https://github.com/civicrm/civicrm-core/pull/14404))** +- **dev/core996 Ensure that the oldest created_date is retained no matter… ([14368](https://github.com/civicrm/civicrm-core/pull/14368))** -- **dev/core#905 Add contribution recur statuses 'Processing' and 'Failing' ([14395](https://github.com/civicrm/civicrm-core/pull/14395))** +- **dev/core#1004 Fix regression causing notices on components screen ([14393](https://github.com/civicrm/civicrm-core/pull/14393))** -- **Allow updating ENGINE_CONFIG for System.updatelogtables ([14348](https://github.com/civicrm/civicrm-core/pull/14348))** +- **dev/core#1010 pledge_acknowledge template - capitalization and greeting ([14465](https://github.com/civicrm/civicrm-core/pull/14465))** -- **Force link in confirmation email to be front-end ([14389](https://github.com/civicrm/civicrm-core/pull/14389))** +- **dev/core#1014 fix e-notice regression ([14426](https://github.com/civicrm/civicrm-core/pull/14426))** -- **dev/Core#785: Extend addField to support select2 widget ([14416](https://github.com/civicrm/civicrm-core/pull/14416))** +- **dev/core#1022 - Manage Case deleted activities search filter no longer working ([14445](https://github.com/civicrm/civicrm-core/pull/14445))** -- **5.14 ([14417](https://github.com/civicrm/civicrm-core/pull/14417))** +- **dev/core#1023 - E_NOTICE when creating bulk SMS ([14449](https://github.com/civicrm/civicrm-core/pull/14449))** -- **Add angular-xeditable to angular ([14414](https://github.com/civicrm/civicrm-core/pull/14414))** +- **dev/core#1025 fix unreleased regression on contact.get with custom fields ([14473](https://github.com/civicrm/civicrm-core/pull/14473))** -- **dev/core#1004 Fix regression causing notices on components screen ([14393](https://github.com/civicrm/civicrm-core/pull/14393))** +- **Add CRM_Utils_System::sendResponse(). Fix AssetBuilder's status-code on WP. ([14468](https://github.com/civicrm/civicrm-core/pull/14468))** -- **5.14 ([14413](https://github.com/civicrm/civicrm-core/pull/14413))** +- **Fix Exception api to save lower id number as contact 1 ([14448](https://github.com/civicrm/civicrm-core/pull/14448))** -- **dev/core#389 [preliminary cleanup+ test] Standardise metadat for custom field ([14401](https://github.com/civicrm/civicrm-core/pull/14401))** +- **Fix Exception to remove result from duplicates ([14447](https://github.com/civicrm/civicrm-core/pull/14447))** -- **dev/core#985 Fix trailing slash for urls on Windows ([14405](https://github.com/civicrm/civicrm-core/pull/14405))** +- **Permit sort_name as a url parameter on advanced search ([14475](https://github.com/civicrm/civicrm-core/pull/14475))** -- **Add EntityPageTrait ([14399](https://github.com/civicrm/civicrm-core/pull/14399))** +- **Fix version for pledge message update, also remove 'please print' ([14469](https://github.com/civicrm/civicrm-core/pull/14469))** -- **[NFC] PHPCS fixes. ([14402](https://github.com/civicrm/civicrm-core/pull/14402))** +- **Wrap titles in metadata in ts on payment.create api ([14450](https://github.com/civicrm/civicrm-core/pull/14450))** -- **[REF] Stop passing cacheKey to refillCache ([14337](https://github.com/civicrm/civicrm-core/pull/14337))** +- **[Outbound mail admin form] fix some more notices resulting from recent change ([14433](https://github.com/civicrm/civicrm-core/pull/14433))** -- **Update test files to use PHPUnit6 notiation for classes ([14387](https://github.com/civicrm/civicrm-core/pull/14387))** +- **Fix upgrade on participant_register date ([14427](https://github.com/civicrm/civicrm-core/pull/14427))** -- **Set title properly on Move/Copy/File on Case popup ([14347](https://github.com/civicrm/civicrm-core/pull/14347))** +- **Misc translation 'ts' fixes ([14467](https://github.com/civicrm/civicrm-core/pull/14467))** -- **Set new inactive statuses as 'Chargeback' does not exist on new installs and that breaks Contributionrecur.create API ([14398](https://github.com/civicrm/civicrm-core/pull/14398))** +- **Conditionally use Drupal's jQuery only if available ([14442](https://github.com/civicrm/civicrm-core/pull/14442))** -- **Use data provider to test both api versions ([14153](https://github.com/civicrm/civicrm-core/pull/14153))** +- **Don't run search when editing smartgroup criteria ([14464](https://github.com/civicrm/civicrm-core/pull/14464))** -- **Regenerate Event DAO for i18n ([14396](https://github.com/civicrm/civicrm-core/pull/14396))** +- **Add Contact.get_merge_conflicts api ([14394](https://github.com/civicrm/civicrm-core/pull/14394))** -- **[REF] dev/core#998 make processDupes testable & add test ([14370](https://github.com/civicrm/civicrm-core/pull/14370))** +- **Add api for Dedupe.getduplicates ([14411](https://github.com/civicrm/civicrm-core/pull/14411))** -- **[code-quality] [jcalendar] remove jcalendar usage from participant_register_date on event search ([14330](https://github.com/civicrm/civicrm-core/pull/14330))** +- **Avoid logging error message if status check query fails. ([14363](https://github.com/civicrm/civicrm-core/pull/14363))** -- **Deprecate creating recipients from MailingJob.create. ([14097](https://github.com/civicrm/civicrm-core/pull/14097))** +- **Change Activity tag to use select2 ([14247](https://github.com/civicrm/civicrm-core/pull/14247))** -- **dev/core#953 Add test for updating email via import & ensuring it is primary ([14225](https://github.com/civicrm/civicrm-core/pull/14225))** +- **Fix running of CRM_Utils_MoneyTest on PHPUnit6+ ([14424](https://github.com/civicrm/civicrm-core/pull/14424))** -- **dev/core#389 [preliminary cleanup] Standardise metadata for custom field use ([14386](https://github.com/civicrm/civicrm-core/pull/14386))** +- **Improve formatting for settings checkboxes ([14419](https://github.com/civicrm/civicrm-core/pull/14419))** -- **[REF] Remove reference to 'changePaymentInstrument' from updateFinancialAccounts as never passed in ([14353](https://github.com/civicrm/civicrm-core/pull/14353))** +- **Caches - Normalize dependency on php-cache integration-tests ([14423](https://github.com/civicrm/civicrm-core/pull/14423))** -- **Switch to calling Payment.create api when processing a refund from AdditionalPayment form ([14317](https://github.com/civicrm/civicrm-core/pull/14317))** +- **phpunit6 - Implement TAP printer ([14421](https://github.com/civicrm/civicrm-core/pull/14421))** -- **CRM_Extension_System - Only allow `test.*` extensions during headless testing. Hide from regular users. ([14392](https://github.com/civicrm/civicrm-core/pull/14392))** +- **Try running unit tests on phpunit6 ([14404](https://github.com/civicrm/civicrm-core/pull/14404))** -- **Wysiwyg support for i18n event fields ([14384](https://github.com/civicrm/civicrm-core/pull/14384))** +- **Allow updating ENGINE_CONFIG for System.updatelogtables ([14348](https://github.com/civicrm/civicrm-core/pull/14348))** -- **[NFC] Update package-lock and civicrm_generated to fix langague issues ([14385](https://github.com/civicrm/civicrm-core/pull/14385))** +- **Force link in confirmation email to be front-end ([14389](https://github.com/civicrm/civicrm-core/pull/14389))** -- **dev/core#980 [phpunit test] update phpunit extends class to support later versions ([14333](https://github.com/civicrm/civicrm-core/pull/14333))** +- **Add angular-xeditable to angular ([14414](https://github.com/civicrm/civicrm-core/pull/14414))** -- **dev/financial#59 Fix unreleased regression on batch form ([14377](https://github.com/civicrm/civicrm-core/pull/14377))** +- **Add EntityPageTrait ([14399](https://github.com/civicrm/civicrm-core/pull/14399))** -- **dev/core#723 Fix fatal error when trying to merge contacts with a cus… ([14325](https://github.com/civicrm/civicrm-core/pull/14325))** +- **Update test files to use PHPUnit6 notiation for classes ([14387](https://github.com/civicrm/civicrm-core/pull/14387))** -- **dev/core#994 remove Thousands Separator can not have more than 1 character rule ([14376](https://github.com/civicrm/civicrm-core/pull/14376))** +- **Set title properly on Move/Copy/File on Case popup ([14347](https://github.com/civicrm/civicrm-core/pull/14347))** -- **5.14 ([14383](https://github.com/civicrm/civicrm-core/pull/14383))** +- **Set new inactive statuses as 'Chargeback' does not exist on new installs and that breaks Contributionrecur.create API ([14398](https://github.com/civicrm/civicrm-core/pull/14398))** -- **5.14 ([14380](https://github.com/civicrm/civicrm-core/pull/14380))** +- **Use data provider to test both api versions ([14153](https://github.com/civicrm/civicrm-core/pull/14153))** -- **dev/core996 Ensure that the oldest created_date is retained no matter… ([14368](https://github.com/civicrm/civicrm-core/pull/14368))** +- **Regenerate Event DAO for i18n ([14396](https://github.com/civicrm/civicrm-core/pull/14396))** -- **[REF] Activity Summary report - move temp table generation etc from postProcess to buildQuery, remove postProcess, don't skip in unit tests ([14375](https://github.com/civicrm/civicrm-core/pull/14375))** +- **[code-quality] [jcalendar] remove jcalendar usage from participant_register_date on event search ([14330](https://github.com/civicrm/civicrm-core/pull/14330))** -- **[NFC] Update civicrm_generated data file following addition of contri… ([14371](https://github.com/civicrm/civicrm-core/pull/14371))** +- **Deprecate creating recipients from MailingJob.create. ([14097](https://github.com/civicrm/civicrm-core/pull/14097))** -- **dev/core#905 Separate contribution_recur status_id option group from contribution option group ([14343](https://github.com/civicrm/civicrm-core/pull/14343))** +- **Switch to calling Payment.create api when processing a refund from AdditionalPayment form ([14317](https://github.com/civicrm/civicrm-core/pull/14317))** -- **5.14 ([14369](https://github.com/civicrm/civicrm-core/pull/14369))** +- **CRM_Extension_System - Only allow `test.*` extensions during headless testing. Hide from regular users. ([14392](https://github.com/civicrm/civicrm-core/pull/14392))** -- **[REF] move calculation of migrationInfo into the function that uses it ([14365](https://github.com/civicrm/civicrm-core/pull/14365))** +- **Wysiwyg support for i18n event fields ([14384](https://github.com/civicrm/civicrm-core/pull/14384))** - **Fix inconsistent handling when searching contribution text fields ([14354](https://github.com/civicrm/civicrm-core/pull/14354))** -- **[REF] extract buildClause from CRM_Report_Form_Event_Income ([14098](https://github.com/civicrm/civicrm-core/pull/14098))** - - **Fix name of cache key column to be all lower case rather than camel c… ([14359](https://github.com/civicrm/civicrm-core/pull/14359))** - **Remove confusing pass params by ref ([14360](https://github.com/civicrm/civicrm-core/pull/14360))** -- **dev/core#982 add dedupe.getstatistics api ([14298](https://github.com/civicrm/civicrm-core/pull/14298))** - - **Translation in billingblock.tpl - dropping 'Information' ([14358](https://github.com/civicrm/civicrm-core/pull/14358))** - **Don't apply api3 pre/post processing to api4 actions ([14357](https://github.com/civicrm/civicrm-core/pull/14357))** - **Fix bug where contribution status is mishandled if label is changed ([14352](https://github.com/civicrm/civicrm-core/pull/14352))** -- **5.14 ([14356](https://github.com/civicrm/civicrm-core/pull/14356))** - -- **dev/core#627 Extend a unit test to verify fix made by Sunil ([14350](https://github.com/civicrm/civicrm-core/pull/14350))** - - **Remove duplicate line in case BAO ([14345](https://github.com/civicrm/civicrm-core/pull/14345))** - **correct syntax "IS NOT NULL" to get pledge payment count ([13374](https://github.com/civicrm/civicrm-core/pull/13374))** -- **[REF] Remove input format function from deprecated utils to the only place that calls it ([14342](https://github.com/civicrm/civicrm-core/pull/14342))** - -- **[NFC] phpdoc cleanup ([14335](https://github.com/civicrm/civicrm-core/pull/14335))** - -- **Remove never-called function _civicrm_api3_deprecated_contact_check_custom_params ([14341](https://github.com/civicrm/civicrm-core/pull/14341))** - -- **[REF] extract isLiveMode ([14336](https://github.com/civicrm/civicrm-core/pull/14336))** - -- **[NFC] Further tests tidy up following removing of dbunit ([14344](https://github.com/civicrm/civicrm-core/pull/14344))** - - **Fix fatal error when full group by mysql mode enabled & selecting contacts ([14331](https://github.com/civicrm/civicrm-core/pull/14331))** -- **Unit test for FGB error in #14331 ([14340](https://github.com/civicrm/civicrm-core/pull/14340))** - -- **[REF] use generic loadStandardSearchOptionsFromUrl ([14338](https://github.com/civicrm/civicrm-core/pull/14338))** +- **Reduce cache bypasses - do not bypass custom metadata cache in setGroupTree ([14292](https://github.com/civicrm/civicrm-core/pull/14292))** -- **dev/core#898: use user.login route for D8 login URL instead of user.page ([14138](https://github.com/civicrm/civicrm-core/pull/14138))** - -- **dev/core#913 - update autogenerated .htaccess for apache 2.4 ([14158](https://github.com/civicrm/civicrm-core/pull/14158))** - -- ** [dbunit test] remove dbunit dependency ([14328](https://github.com/civicrm/civicrm-core/pull/14328))** - -- ** Reduce cache bypasses - do not bypass custom metadata cache in setGroupTree ([14292](https://github.com/civicrm/civicrm-core/pull/14292))** - -- **Fix test / possible live error on submitting credit card renewals ([14316](https://github.com/civicrm/civicrm-core/pull/14316))** - -- **[REF] Extract function to get cached duplicate matches ([14324](https://github.com/civicrm/civicrm-core/pull/14324))** - -- **[REF] minor code re-org ([14318](https://github.com/civicrm/civicrm-core/pull/14318))** - -- **[NFC] Docblock fixes ([14323](https://github.com/civicrm/civicrm-core/pull/14323))** - -- **dev/core#879 SMTP help text is misleading - references the wrong admin screen ([14329](https://github.com/civicrm/civicrm-core/pull/14329))** - -- **dev/core#830 Expose cancel_reason field by cleaning up the cancel template to use entity field template ([13997](https://github.com/civicrm/civicrm-core/pull/13997))** - -- **dev/core#980 [dbunit] remove dependency on discontinued dbunit ([14321](https://github.com/civicrm/civicrm-core/pull/14321))** - -- **(NFC) Update node package versions to latest ones ([14087](https://github.com/civicrm/civicrm-core/pull/14087))** - -- **dev/core/issues/743, Donot join relationship table when not required ([14082](https://github.com/civicrm/civicrm-core/pull/14082))** - -- **[NFC] Fix issue with Job Manager Test giving out a warning ([14327](https://github.com/civicrm/civicrm-core/pull/14327))** - -- **5.14 ([14326](https://github.com/civicrm/civicrm-core/pull/14326))** +- **[dbunit] remove dependencies on discontinued dbunit test package ([14319](https://github.com/civicrm/civicrm-core/pull/14319))** -- **Add unit test for merge handling on custom data. ([14310](https://github.com/civicrm/civicrm-core/pull/14310))** +- **[dbunit] remove dbunit dependency from MembershipRenewalTest ([14315](https://github.com/civicrm/civicrm-core/pull/14315))** -- **[NFC] Fix comment block for variable declarations ([14314](https://github.com/civicrm/civicrm-core/pull/14314))** +- **Fix legacy IPN endpoint for Drupal (gitlab issue 973) ([14272](https://github.com/civicrm/civicrm-core/pull/14272))** -- **[dbunit] remove dependencies on discontinued dbunit test package ([14319](https://github.com/civicrm/civicrm-core/pull/14319))** +- **Make apiRequst nextId accessible for api4 constructor ([14311](https://github.com/civicrm/civicrm-core/pull/14311))** -- **[dbunit] remove dbunit dependency from MembershipRenewalTest ([14315](https://github.com/civicrm/civicrm-core/pull/14315))** +- **crmRouteBinder - Remove params from url if they equal their defaults ([14211](https://github.com/civicrm/civicrm-core/pull/14211))** -- **(dev/core#959) Expose contribution page in Contribution Summary report ([14249](https://github.com/civicrm/civicrm-core/pull/14249))** +- **Fix deprecation notice on manage events page ([14289](https://github.com/civicrm/civicrm-core/pull/14289))** -- **[REF] Cleanup input & output on paymentActivityCreate & improve test ([14269](https://github.com/civicrm/civicrm-core/pull/14269))** +- **Try enabling api4 extension in test suite ([14241](https://github.com/civicrm/civicrm-core/pull/14241))** -- **Fix legacy IPN endpoint for Drupal (gitlab issue 973) ([14272](https://github.com/civicrm/civicrm-core/pull/14272))** +- **Declare API Key as a protected field for future use ([14274](https://github.com/civicrm/civicrm-core/pull/14274))** -- **dev/core#980 [test-dbunit] Cleanup profile test to not use discontinuted dbunit ([14279](https://github.com/civicrm/civicrm-core/pull/14279))** +- **add developer tab for summary report ([14254](https://github.com/civicrm/civicrm-core/pull/14254))** -- **dev/drupal#19 Drupal8: fix bootstrap when used by the REST API ([14302](https://github.com/civicrm/civicrm-core/pull/14302))** +- **Remove wasteful double-caching of settings metadata ([14259](https://github.com/civicrm/civicrm-core/pull/14259))** -- **dev/core#981 Sorting participants ignored search values. ([14313](https://github.com/civicrm/civicrm-core/pull/14313))** +- **Fix financial acl permissions to respect check_permissions ([14118](https://github.com/civicrm/civicrm-core/pull/14118))** -- **dev/financial#56 Fix inappropriate sales tax row addition ([14309](https://github.com/civicrm/civicrm-core/pull/14309))** +- **When creating relationship types don't munge names ([14216](https://github.com/civicrm/civicrm-core/pull/14216))** -- **dev/joomla#11 Fix php warning when viewing profiles ([14312](https://github.com/civicrm/civicrm-core/pull/14312))** +- **Remove broken delete from customGroupCreate ([14239](https://github.com/civicrm/civicrm-core/pull/14239))** -- **NFC Fix DAO Style issues ([14307](https://github.com/civicrm/civicrm-core/pull/14307))** +- **Remove CIVICRM_TEMP_FORCE_UTF8; deprecate TempTable::setUtf8() ([14004](https://github.com/civicrm/civicrm-core/pull/14004))** -- **[NFC] reformat UFFieldTest ([14308](https://github.com/civicrm/civicrm-core/pull/14308))** +- **Pass the RFC 3164 severity level thru to drupal watchdog. ([14185](https://github.com/civicrm/civicrm-core/pull/14185))** -- **Make apiRequst nextId accessible for api4 constructor ([14311](https://github.com/civicrm/civicrm-core/pull/14311))** +- **Stop overriding is_active default when saving new relationship ([14199](https://github.com/civicrm/civicrm-core/pull/14199))** -- **crmRouteBinder - Remove params from url if they equal their defaults ([14211](https://github.com/civicrm/civicrm-core/pull/14211))** +- **contributor-keys file - jira/lab.c.o username fix ([14200](https://github.com/civicrm/civicrm-core/pull/14200))** -- **[REF] extract buildGroupTree function ([14303](https://github.com/civicrm/civicrm-core/pull/14303))** +- **IDE re-format of tools directory ([14177](https://github.com/civicrm/civicrm-core/pull/14177))** -- **[REF] Test class cleanup - Extract function to create nuanced custom fields to a trait ([14301](https://github.com/civicrm/civicrm-core/pull/14301))** +- **Enotice fix on creating a smart group ([14180](https://github.com/civicrm/civicrm-core/pull/14180))** -- **dev/core#888 - Backoffice participant transfer form does not populate… ([14102](https://github.com/civicrm/civicrm-core/pull/14102))** +- **Don't call session_start() before CMS bootstrap (PHP 7.2 compat) ([14074](https://github.com/civicrm/civicrm-core/pull/14074))** -- **[NFC] fix comment blocks capitalising null ([14306](https://github.com/civicrm/civicrm-core/pull/14306))** +- **Cache/IntegrationTests - Remove. This can be replaced by composer dependency ([255](https://github.com/civicrm/civicrm-packages/pull/255))** -- **[NFC] fix more places where var is declared as boolean rather than bool ([14305](https://github.com/civicrm/civicrm-core/pull/14305))** +- **Get LegacySimpleCacheTest complient with phpunit6+ ([254](https://github.com/civicrm/civicrm-packages/pull/254))** -- **[NFC] formatting & comment fixes - Regenerate DAO files ([14304](https://github.com/civicrm/civicrm-core/pull/14304))** +## Miscellany -- **[NFC] ProfileTest class - formatting & general cleanup ([14282](https://github.com/civicrm/civicrm-core/pull/14282))** +- **Remove never-called function + _civicrm_api3_deprecated_contact_check_custom_params + ([14341](https://github.com/civicrm/civicrm-core/pull/14341))** -- **[NFC] Add trailing comma to pseudoconstant array in DAOs ([14295](https://github.com/civicrm/civicrm-core/pull/14295))** +- **Unit test for FGB error in #14331 + ([14340](https://github.com/civicrm/civicrm-core/pull/14340))** -- **[REF] Fix pointless use of CRM_Utils_Array::value in Campaign BAO ([14300](https://github.com/civicrm/civicrm-core/pull/14300))** +- **Test tweaks that *might* help with intermittant test weirdness + ([14458](https://github.com/civicrm/civicrm-core/pull/14458))** -- **[NFC] Fix variable types in DAO doc blocks ([14294](https://github.com/civicrm/civicrm-core/pull/14294))** +- **[TEST SUITE] Remove some use of dbunit from tests + ([14271](https://github.com/civicrm/civicrm-core/pull/14271))** -- **[NFC] fix docblock types from boolean to bool ([14296](https://github.com/civicrm/civicrm-core/pull/14296))** +- **Test cleanup to remove references to discontinued package dbunit + ([14276](https://github.com/civicrm/civicrm-core/pull/14276))** -- **[code-cleanup] remove orderBy param from getDuplicatePairs, it is not used ([14297](https://github.com/civicrm/civicrm-core/pull/14297))** +- **[dbunit test] remove dbunit dependency + ([14328](https://github.com/civicrm/civicrm-core/pull/14328))** -- **dev/core#980 [dbunit] QueryTest Remove dbunit dependency on discontinued dbunit ([14283](https://github.com/civicrm/civicrm-core/pull/14283))** +- **Add unit test for merge handling on custom data. + ([14310](https://github.com/civicrm/civicrm-core/pull/14310))** -- **[NFC] array formatting, some comments ([14291](https://github.com/civicrm/civicrm-core/pull/14291))** +- **Fix test / possible live error on submitting credit card renewals + ([14316](https://github.com/civicrm/civicrm-core/pull/14316))** -- **[REF] Simplify ACL page template ([14288](https://github.com/civicrm/civicrm-core/pull/14288))** +- **Update testGetActivityAccessCiviCRMEnough test for clarity + ([14226](https://github.com/civicrm/civicrm-core/pull/14226))** -- **dev/financial#54 Fix mishandling of deferred revenue settings ([14267](https://github.com/civicrm/civicrm-core/pull/14267))** +- **[REF] Move retrieval of basicSearchFields to 'get' fn + ([14476](https://github.com/civicrm/civicrm-core/pull/14476))** -- **Fix deprecation notice on manage events page ([14289](https://github.com/civicrm/civicrm-core/pull/14289))** +- **[REF] Remove input format function from deprecated utils to the only place + that calls it ([14342](https://github.com/civicrm/civicrm-core/pull/14342))** -- **5.14 to master ([14285](https://github.com/civicrm/civicrm-core/pull/14285))** +- **[REF] extract isLiveMode + ([14336](https://github.com/civicrm/civicrm-core/pull/14336))** -- **dev/drupal#19 Drupal8: Implement set UF locale/language (affects mailing tokens) ([12152](https://github.com/civicrm/civicrm-core/pull/12152))** +- **[REF] use generic loadStandardSearchOptionsFromUrl + ([14338](https://github.com/civicrm/civicrm-core/pull/14338))** -- **[NFC] Update Language to be more user friendly when checking logs ([14278](https://github.com/civicrm/civicrm-core/pull/14278))** +- **[REF] Extract function to get cached duplicate matches + ([14324](https://github.com/civicrm/civicrm-core/pull/14324))** -- **Test cleanup to remove references to discontinued package dbunit ([14276](https://github.com/civicrm/civicrm-core/pull/14276))** +- **[REF] minor code re-org + ([14318](https://github.com/civicrm/civicrm-core/pull/14318))** -- **Try enabling api4 extension in test suite ([14241](https://github.com/civicrm/civicrm-core/pull/14241))** +- **[REF] Remove extraneous variable + ([14261](https://github.com/civicrm/civicrm-core/pull/14261))** -- **Declare API Key as a protected field for future use ([14274](https://github.com/civicrm/civicrm-core/pull/14274))** +- **[REF] Centralize logic for resolving settings pseudoconstants + ([14264](https://github.com/civicrm/civicrm-core/pull/14264))** -- **dev/core#369 Prevent hard fail of API Job when SMS provider has been deleted ([14266](https://github.com/civicrm/civicrm-core/pull/14266))** +- **[REF] Super Minor code readability fix + ([14258](https://github.com/civicrm/civicrm-core/pull/14258))** -- **[TEST SUITE] Remove some use of dbunit from tests ([14271](https://github.com/civicrm/civicrm-core/pull/14271))** +- **[ref] Move copyCustomFields function from Event to Core_DAO for + re-usablibilty ([14171](https://github.com/civicrm/civicrm-core/pull/14171))** -- **[NFC] array formatting in CRM_Dedupe_MergerTest ([14273](https://github.com/civicrm/civicrm-core/pull/14273))** +- **[ref] Remove reference symbol from 2 variables + ([14270](https://github.com/civicrm/civicrm-core/pull/14270))** -- **add developer tab for summary report ([14254](https://github.com/civicrm/civicrm-core/pull/14254))** +- **[cleanup] Remove deprecated pattern &CRM_Core_Config::singleton() + ([14178](https://github.com/civicrm/civicrm-core/pull/14178))** -- **[ref] Remove reference symbol from 2 variables ([14270](https://github.com/civicrm/civicrm-core/pull/14270))** +- **REF Refactor to reduce duplication on payment forms + ([14206](https://github.com/civicrm/civicrm-core/pull/14206))** -- **[REF][Test] Remove call to CRM_Contribute_BAO_Contribution::recordAdditionalPayment in favour of payment create ([14137](https://github.com/civicrm/civicrm-core/pull/14137))** +- **[REF+ test] start process of cleaning up payment activity handling + ([14198](https://github.com/civicrm/civicrm-core/pull/14198))** -- **[REF+test] clean up code for getting labels for merge screen, stdise ([14260](https://github.com/civicrm/civicrm-core/pull/14260))** +- **[REF][Test] Remove call to + CRM_Contribute_BAO_Contribution::recordAdditionalPayment in favour of payment + create ([14137](https://github.com/civicrm/civicrm-core/pull/14137))** -- **[REF] Centralize logic for resolving settings pseudoconstants ([14264](https://github.com/civicrm/civicrm-core/pull/14264))** +- **[REF+test] clean up code for getting labels for merge screen, stdise + ([14260](https://github.com/civicrm/civicrm-core/pull/14260))** -- **Remove wasteful double-caching of settings metadata ([14259](https://github.com/civicrm/civicrm-core/pull/14259))** +- **[REF] Simplify ACL page template + ([14288](https://github.com/civicrm/civicrm-core/pull/14288))** -- **dev/core#964 Add start date and end date values on page contribution widget ajax response ([14262](https://github.com/civicrm/civicrm-core/pull/14262))** +- **[REF] Fix pointless use of CRM_Utils_Array::value in Campaign BAO + ([14300](https://github.com/civicrm/civicrm-core/pull/14300))** -- **dev/core/966 skip urlencode for email in elavon xml ([14263](https://github.com/civicrm/civicrm-core/pull/14263))** +- **[code-cleanup] remove orderBy param from getDuplicatePairs, it is not used + ([14297](https://github.com/civicrm/civicrm-core/pull/14297))** -- **[REF] Remove extraneous variable ([14261](https://github.com/civicrm/civicrm-core/pull/14261))** +- **[REF] extract buildGroupTree function + ([14303](https://github.com/civicrm/civicrm-core/pull/14303))** -- **[REF] Super Minor code readability fix ([14258](https://github.com/civicrm/civicrm-core/pull/14258))** +- **[REF] Test class cleanup - Extract function to create nuanced custom fields + to a trait ([14301](https://github.com/civicrm/civicrm-core/pull/14301))** -- **5.14 ([14257](https://github.com/civicrm/civicrm-core/pull/14257))** +- **[REF] Cleanup input & output on paymentActivityCreate & improve test + ([14269](https://github.com/civicrm/civicrm-core/pull/14269))** -- **5.14 ([14248](https://github.com/civicrm/civicrm-core/pull/14248))** +- **[REF] move calculation of migrationInfo into the function that uses it + ([14365](https://github.com/civicrm/civicrm-core/pull/14365))** -- **Remove broken delete from customGroupCreate ([14239](https://github.com/civicrm/civicrm-core/pull/14239))** +- **[REF] extract buildClause from CRM_Report_Form_Event_Income + ([14098](https://github.com/civicrm/civicrm-core/pull/14098))** -- **dev/core#926 [ref] adds a test & does a preliminary extraction ([14181](https://github.com/civicrm/civicrm-core/pull/14181))** +- **[REF] Activity Summary report - move temp table generation etc from + postProcess to buildQuery, remove postProcess, don't skip in unit tests + ([14375](https://github.com/civicrm/civicrm-core/pull/14375))** -- **dev/core#932 Fix dedupe contacts flip selection ([14195](https://github.com/civicrm/civicrm-core/pull/14195))** +- **[REF] Activity form - very minor tidy up + ([14434](https://github.com/civicrm/civicrm-core/pull/14434))** -- **dev/core#896 - fix notice warning on closing a case ([14160](https://github.com/civicrm/civicrm-core/pull/14160))** +- **[REF] Stop passing cacheKey to refillCache + ([14337](https://github.com/civicrm/civicrm-core/pull/14337))** -- **REF Refactor to reduce duplication on payment forms ([14206](https://github.com/civicrm/civicrm-core/pull/14206))** +- **[REF] dev/core#998 make processDupes testable & add test + ([14370](https://github.com/civicrm/civicrm-core/pull/14370))** -- **Update testGetActivityAccessCiviCRMEnough test for clarity ([14226](https://github.com/civicrm/civicrm-core/pull/14226))** +- **[REF] Remove reference to 'changePaymentInstrument' from + updateFinancialAccounts as never passed in + ([14353](https://github.com/civicrm/civicrm-core/pull/14353))** -- **5.14 ([14238](https://github.com/civicrm/civicrm-core/pull/14238))** +- **[NFC][test-fix] centralise use of assertLike for comparing sql + ([14470](https://github.com/civicrm/civicrm-core/pull/14470))** -- **Fix financial acl permissions to respect check_permissions ([14118](https://github.com/civicrm/civicrm-core/pull/14118))** +- **[nfc] [test] Skip testGetFromTo on date transition + ([14472](https://github.com/civicrm/civicrm-core/pull/14472))** -- **When creating relationship types don't munge names ([14216](https://github.com/civicrm/civicrm-core/pull/14216))** +- **[NFC] Fix issue with Job Manager Test giving out a warning + ([14327](https://github.com/civicrm/civicrm-core/pull/14327))** -- **5.14 to master ([14227](https://github.com/civicrm/civicrm-core/pull/14227))** +- **[NFC] Fix comment block for variable declarations + ([14314](https://github.com/civicrm/civicrm-core/pull/14314))** -- **dev/core#945 - fix use of $this error in static method ([14217](https://github.com/civicrm/civicrm-core/pull/14217))** +- **(NFC) Update node package versions to latest ones + ([14087](https://github.com/civicrm/civicrm-core/pull/14087))** -- **Remove CIVICRM_TEMP_FORCE_UTF8; deprecate TempTable::setUtf8() ([14004](https://github.com/civicrm/civicrm-core/pull/14004))** +- **[NFC] Update civicrm_generated data file following addition of contri… + ([14371](https://github.com/civicrm/civicrm-core/pull/14371))** -- **Pass the RFC 3164 severity level thru to drupal watchdog. ([14185](https://github.com/civicrm/civicrm-core/pull/14185))** +- **(NFC) Remove without param tests + ([14454](https://github.com/civicrm/civicrm-core/pull/14454))** -- **(dev/core#705) Disabling Alphabetical Pager is not respected for events ([14203](https://github.com/civicrm/civicrm-core/pull/14203))** +- **[NFC] PHPCS fixes. + ([14402](https://github.com/civicrm/civicrm-core/pull/14402))** -- **5.14 ([14205](https://github.com/civicrm/civicrm-core/pull/14205))** +- **[NFC] Update package-lock and civicrm_generated to fix langague issues + ([14385](https://github.com/civicrm/civicrm-core/pull/14385))** -- **[REF+ test] start process of cleaning up payment activity handling ([14198](https://github.com/civicrm/civicrm-core/pull/14198))** +- **[NFC] phpdoc cleanup + ([14335](https://github.com/civicrm/civicrm-core/pull/14335))** -- **dev/core#927 [ref] Extract contribution.cancel function ([14197](https://github.com/civicrm/civicrm-core/pull/14197))** +- **[NFC] Fix variable types in DAO doc blocks + ([14294](https://github.com/civicrm/civicrm-core/pull/14294))** -- **Stop overriding is_active default when saving new relationship ([14199](https://github.com/civicrm/civicrm-core/pull/14199))** +- **[NFC] fix docblock types from boolean to bool + ([14296](https://github.com/civicrm/civicrm-core/pull/14296))** -- **5.14 ([14202](https://github.com/civicrm/civicrm-core/pull/14202))** +- **[NFC] array formatting in CRM_Dedupe_MergerTest + ([14273](https://github.com/civicrm/civicrm-core/pull/14273))** -- **contributor-keys file - jira/lab.c.o username fix ([14200](https://github.com/civicrm/civicrm-core/pull/14200))** +- **[NFC] Update Language to be more user friendly when checking logs + ([14278](https://github.com/civicrm/civicrm-core/pull/14278))** -- **IDE re-format of tools directory ([14177](https://github.com/civicrm/civicrm-core/pull/14177))** +- **[NFC] array formatting, some comments + ([14291](https://github.com/civicrm/civicrm-core/pull/14291))** -- **Enotice fix on creating a smart group ([14180](https://github.com/civicrm/civicrm-core/pull/14180))** +- **[NFC] fix comment blocks capitalising null + ([14306](https://github.com/civicrm/civicrm-core/pull/14306))** -- **5.14 ([14192](https://github.com/civicrm/civicrm-core/pull/14192))** +- **[NFC] fix more places where var is declared as boolean rather than bool + ([14305](https://github.com/civicrm/civicrm-core/pull/14305))** -- **Don't call session_start() before CMS bootstrap (PHP 7.2 compat) ([14074](https://github.com/civicrm/civicrm-core/pull/14074))** +- **[NFC] formatting & comment fixes - Regenerate DAO files + ([14304](https://github.com/civicrm/civicrm-core/pull/14304))** -- **[ref] Move copyCustomFields function from Event to Core_DAO for re-usablibilty ([14171](https://github.com/civicrm/civicrm-core/pull/14171))** +- **[NFC] ProfileTest class - formatting & general cleanup + ([14282](https://github.com/civicrm/civicrm-core/pull/14282))** -- **dev/translation#26 Fix Notice errors caused by l10n rewriting of quer… ([14152](https://github.com/civicrm/civicrm-core/pull/14152))** +- **[NFC] Add trailing comma to pseudoconstant array in DAOs + ([14295](https://github.com/civicrm/civicrm-core/pull/14295))** -- **[cleanup] Remove deprecated pattern &CRM_Core_Config::singleton() ([14178](https://github.com/civicrm/civicrm-core/pull/14178))** +- **[NFC] array formatting in api_v3_paymentTest class + ([14451](https://github.com/civicrm/civicrm-core/pull/14451))** -- **dev/core#562 [cleanup] remove some more instances of ->free() ([14179](https://github.com/civicrm/civicrm-core/pull/14179))** +- **[NFC] Update Exception DAO class + ([14482](https://github.com/civicrm/civicrm-core/pull/14482))** -- **Cache/IntegrationTests - Remove. This can be replaced by composer dependency ([255](https://github.com/civicrm/civicrm-packages/pull/255))** +- **[NFC] Further tests tidy up following removing of dbunit + ([14344](https://github.com/civicrm/civicrm-core/pull/14344))** -- **Get LegacySimpleCacheTest complient with phpunit6+ ([254](https://github.com/civicrm/civicrm-packages/pull/254))** +- **[NFC] Docblock fixes + ([14323](https://github.com/civicrm/civicrm-core/pull/14323))** -- **5.14 ([252](https://github.com/civicrm/civicrm-packages/pull/252))** +- **NFC Fix DAO Style issues + ([14307](https://github.com/civicrm/civicrm-core/pull/14307))** -## Miscellany +- **[NFC] reformat UFFieldTest + ([14308](https://github.com/civicrm/civicrm-core/pull/14308))** ## Credits