From: eileen <emcnaughton@wikimedia.org>
Date: Tue, 26 May 2020 03:50:04 +0000 (+1200)
Subject: [REF] Pass params not-by-reference
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=5ba209bace67c0be9ebbace21cf2c26c6aaa7de3;p=civicrm-core.git

[REF] Pass params not-by-reference

This is only called by one place in core + a deprecated unused class. The details are not used again
---

diff --git a/CRM/Activity/BAO/Activity.php b/CRM/Activity/BAO/Activity.php
index 4a43aade74..20d2f0e072 100644
--- a/CRM/Activity/BAO/Activity.php
+++ b/CRM/Activity/BAO/Activity.php
@@ -1079,10 +1079,10 @@ class CRM_Activity_BAO_Activity extends CRM_Activity_DAO_Activity {
    * @throws \CiviCRM_API3_Exception
    */
   public static function sendEmail(
-    &$contactDetails,
-    &$subject,
-    &$text,
-    &$html,
+    $contactDetails,
+    $subject,
+    $text,
+    $html,
     $emailAddress,
     $userID = NULL,
     $from = NULL,