From: gavk34 <gavhomeltp@gmail.com>
Date: Fri, 27 Nov 2020 20:55:49 +0000 (+0000)
Subject: Resolve #715 Metric for unknown probe (#716)
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=57b2925620b3ea2d3bb20899e16a415c2d5dd95b;p=blackbox_exporter.git

Resolve #715 Metric for unknown probe (#716)

Co-authored-by: Gavin Kelly <gkelly@newsweaver.com>
---

diff --git a/main.go b/main.go
index 0fab28d..24e5504 100644
--- a/main.go
+++ b/main.go
@@ -65,6 +65,11 @@ var (
 		"icmp": prober.ProbeICMP,
 		"dns":  prober.ProbeDNS,
 	}
+
+	moduleUnknownCounter = prometheus.NewCounter(prometheus.CounterOpts{
+		Name: "blackbox_module_unknown_total",
+		Help: "Count of unknown modules requested by probes",
+	})
 )
 
 func probeHandler(w http.ResponseWriter, r *http.Request, c *config.Config, logger log.Logger, rh *resultHistory) {
@@ -75,6 +80,8 @@ func probeHandler(w http.ResponseWriter, r *http.Request, c *config.Config, logg
 	module, ok := c.Modules[moduleName]
 	if !ok {
 		http.Error(w, fmt.Sprintf("Unknown module %q", moduleName), http.StatusBadRequest)
+		level.Debug(logger).Log("msg", "Unknown module", "module", moduleName)
+		moduleUnknownCounter.Add(1)
 		return
 	}
 
@@ -96,6 +103,7 @@ func probeHandler(w http.ResponseWriter, r *http.Request, c *config.Config, logg
 		Name: "probe_duration_seconds",
 		Help: "Returns how long the probe took to complete in seconds",
 	})
+
 	params := r.URL.Query()
 	target := params.Get("target")
 	if target == "" {
@@ -194,6 +202,7 @@ func DebugOutput(module *config.Module, logBuffer *bytes.Buffer, registry *prome
 
 func init() {
 	prometheus.MustRegister(version.NewCollector("blackbox_exporter"))
+	prometheus.MustRegister(moduleUnknownCounter)
 }
 
 func main() {