From: Eileen McNaughton <emcnaughton@wikimedia.org>
Date: Fri, 27 Oct 2023 04:25:36 +0000 (+1300)
Subject: Add a couple of soft deprecations
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=5081f18a755c1898365fc4747a1d844eb597fa1c;p=civicrm-core.git

Add a couple of soft deprecations
---

diff --git a/CRM/Invoicing/Utils.php b/CRM/Invoicing/Utils.php
index 70de2c7d4d..382bc4177d 100644
--- a/CRM/Invoicing/Utils.php
+++ b/CRM/Invoicing/Utils.php
@@ -48,11 +48,9 @@ class CRM_Invoicing_Utils {
   /**
    * Function to call to determine if invoicing is enabled.
    *
-   * Historically the invoicing was declared as a setting but actually
-   * set within contribution_invoice_settings (which stores multiple settings
-   * as an array in a non-standard way).
+   * Use Civi::settings()->get('invoicing') instead.
    *
-   * We check both here. But will deprecate the latter in time.
+   * @deprecated since 5.68 expected removal time to be added when we add noisy deprecation.
    */
   public static function isInvoicingEnabled() {
     return Civi::settings()->get('invoicing');
@@ -61,8 +59,9 @@ class CRM_Invoicing_Utils {
   /**
    * Function to get the tax term.
    *
-   * The value is nested in the contribution_invoice_settings setting - which
-   * is unsupported. Here we have a wrapper function to make later cleanup easier.
+   * Use Civi::settings()->get('tax_term') instead.
+   *
+   * @deprecated since 5.68 expected removal time to be added when we add noisy deprecation.
    */
   public static function getTaxTerm() {
     return Civi::settings()->get('tax_term');