From: eileen Date: Thu, 27 Jun 2019 00:24:43 +0000 (+1200) Subject: Remove a few places where pass by reference is used but does not need to be X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=4f89ebb066b733b6a085ceffd3e99a5bb3fba7bc;p=civicrm-core.git Remove a few places where pass by reference is used but does not need to be --- diff --git a/CRM/Core/BAO/SchemaHandler.php b/CRM/Core/BAO/SchemaHandler.php index 0e21bd549b..7458e6b0b1 100644 --- a/CRM/Core/BAO/SchemaHandler.php +++ b/CRM/Core/BAO/SchemaHandler.php @@ -124,7 +124,7 @@ class CRM_Core_BAO_SchemaHandler { * * @return string */ - public static function buildFieldSQL(&$params, $separator, $prefix) { + public static function buildFieldSQL($params, $separator, $prefix) { $sql = ''; $sql .= $separator; $sql .= str_repeat(' ', 8); @@ -159,7 +159,7 @@ class CRM_Core_BAO_SchemaHandler { * * @return NULL|string */ - public static function buildPrimaryKeySQL(&$params, $separator, $prefix) { + public static function buildPrimaryKeySQL($params, $separator, $prefix) { $sql = NULL; if (!empty($params['primary'])) { $sql .= $separator; @@ -178,7 +178,7 @@ class CRM_Core_BAO_SchemaHandler { * * @return NULL|string */ - public static function buildSearchIndexSQL(&$params, $separator, $prefix, $indexExist = FALSE) { + public static function buildSearchIndexSQL($params, $separator, $prefix, $indexExist = FALSE) { $sql = NULL; // dont index blob @@ -271,7 +271,7 @@ ALTER TABLE {$tableName} * * @return NULL|string */ - public static function buildForeignKeySQL(&$params, $separator, $prefix, $tableName) { + public static function buildForeignKeySQL($params, $separator, $prefix, $tableName) { $sql = NULL; if (!empty($params['fk_table_name']) && !empty($params['fk_field_name'])) { $sql .= $separator;