From: Eileen McNaughton <emcnaughton@wikimedia.org>
Date: Wed, 29 Nov 2023 09:58:26 +0000 (+1300)
Subject: Move the pre-assign of pcpBlock further up
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=432b43b266da7341793a0fa0792c0dcc9a57f06d;p=civicrm-core.git

Move the pre-assign of pcpBlock further up

This is assigned false, & then assigned again if there is a value to prevent notices (already)
but the first assign isn't always done so we still have notices
---

diff --git a/CRM/Contribute/Form/Contribution/ThankYou.php b/CRM/Contribute/Form/Contribution/ThankYou.php
index d24a83b607..c0335261b6 100644
--- a/CRM/Contribute/Form/Contribution/ThankYou.php
+++ b/CRM/Contribute/Form/Contribution/ThankYou.php
@@ -132,9 +132,9 @@ class CRM_Contribute_Form_Contribution_ThankYou extends CRM_Contribute_Form_Cont
 
     $qParams = "reset=1&amp;id={$this->_id}";
     //pcp elements
+    $this->assign('pcpBlock', FALSE);
     if ($this->_pcpId) {
       $qParams .= "&amp;pcpId={$this->_pcpId}";
-      $this->assign('pcpBlock', FALSE);
 
       // display honor roll data only if it's enabled for the PCP page
       if (!empty($this->_pcpInfo['is_honor_roll'])) {