From: Bradley Taylor <bradley.taylor@brightminded.com>
Date: Fri, 2 Jun 2023 16:31:52 +0000 (+0100)
Subject: [REF][PHP8.2] Declare property in CRM_Report_Form_Contribute_Sybunt
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=42d537c047ce77886ef9e390f31cb31225e1c507;p=civicrm-core.git

[REF][PHP8.2] Declare property in CRM_Report_Form_Contribute_Sybunt
---

diff --git a/CRM/Report/Form/Contribute/Sybunt.php b/CRM/Report/Form/Contribute/Sybunt.php
index 8f25969dab..5bad43bde2 100644
--- a/CRM/Report/Form/Contribute/Sybunt.php
+++ b/CRM/Report/Form/Contribute/Sybunt.php
@@ -32,6 +32,11 @@ class CRM_Report_Form_Contribute_Sybunt extends CRM_Report_Form {
    */
   protected $groupFilterNotOptimised = FALSE;
 
+  /**
+   * @var string
+   */
+  protected $statusClause = '';
+
   /**
    * Class constructor.
    */
@@ -334,7 +339,7 @@ class CRM_Report_Form_Contribute_Sybunt extends CRM_Report_Form {
   }
 
   public function where() {
-    $this->_statusClause = "";
+    $this->statusClause = "";
     $clauses = [
       $this->_aliases['civicrm_contribution'] . '.is_test = 0',
       $this->_aliases['civicrm_contribution'] . '.is_template = 0',
@@ -372,7 +377,7 @@ class CRM_Report_Form_Contribute_Sybunt extends CRM_Report_Form {
               if (($fieldName == 'contribution_status_id' ||
                   $fieldName == 'financial_type_id') && !empty($clause)
               ) {
-                $this->_statusClause .= " AND " . $clause;
+                $this->statusClause .= " AND " . $clause;
               }
             }
           }
@@ -452,7 +457,7 @@ class CRM_Report_Form_Contribute_Sybunt extends CRM_Report_Form {
         $sql = "" .
           "{$this->_select} {$this->_from} WHERE {$this->_aliases['civicrm_contact']}.id IN (" .
           implode(',', $contactIds) .
-          ") AND {$this->_aliases['civicrm_contribution']}.is_test = 0 AND {$this->_aliases['civicrm_contribution']}.is_template = 0 {$this->_statusClause} {$this->_groupBy} ";
+          ") AND {$this->_aliases['civicrm_contribution']}.is_test = 0 AND {$this->_aliases['civicrm_contribution']}.is_template = 0 {$this->statusClause} {$this->_groupBy} ";
       }
 
       $current_year = $this->_params['yid_value'];
@@ -507,7 +512,7 @@ class CRM_Report_Form_Contribute_Sybunt extends CRM_Report_Form {
    */
   public function buildChart(&$rows) {
     $graphRows = [];
-    $count = 0;
+    $display = [];
     $current_year = $this->_params['yid_value'];
     $previous_year = $current_year - 1;
     $previous_two_year = $current_year - 2;