From: yashodha <yashodha.chaku@webaccessglobal.com>
Date: Thu, 8 Sep 2016 08:23:32 +0000 (+0530)
Subject: CRM-19293: Dashboard options disappear after CiviContribute Component Settings save
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=3ff9e82487007d603b2ab2c594f7db50e4a410ca;p=civicrm-core.git

CRM-19293: Dashboard options disappear after CiviContribute Component Settings save

----------------------------------------
* CRM-19293: Dashboard options disappear after CiviContribute Component Settings save
  https://issues.civicrm.org/jira/browse/CRM-19293
---

diff --git a/CRM/Admin/Form/Preferences/Contribute.php b/CRM/Admin/Form/Preferences/Contribute.php
index d8a1030388..caa0c55365 100644
--- a/CRM/Admin/Form/Preferences/Contribute.php
+++ b/CRM/Admin/Form/Preferences/Contribute.php
@@ -248,7 +248,7 @@ class CRM_Admin_Form_Preferences_Contribute extends CRM_Admin_Form_Preferences {
     else {
       $setting = explode(CRM_Core_DAO::VALUE_SEPARATOR, substr($values['user_dashboard_options'], 1, -1));
       $invoiceKey = array_search($setKey, $setting);
-      if (!empty($invoiceKey)) {
+      if ($invoiceKey !== FALSE) {
         unset($setting[$invoiceKey]);
       }
       $settingName = CRM_Core_DAO::VALUE_SEPARATOR .