From: eileen <emcnaughton@wikimedia.org>
Date: Mon, 20 Aug 2018 03:48:00 +0000 (+1200)
Subject: Stop returning createdMemberships.
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=3d76bb71e5e2695217572ce1d426a9201cd36176;p=civicrm-core.git

Stop returning createdMemberships.

This parameter is built up purely to set the status message, which I argue should be
set 'as she goes' saving us building up complex variables. Removing this
var will help us simplify the earlier loops
---

diff --git a/CRM/Member/Form/Membership.php b/CRM/Member/Form/Membership.php
index 2caafe6fd2..272b7bf0f0 100644
--- a/CRM/Member/Form/Membership.php
+++ b/CRM/Member/Form/Membership.php
@@ -1103,8 +1103,6 @@ class CRM_Member_Form_Membership extends CRM_Member_Form {
    * Submit function.
    *
    * This is also accessed by unit tests.
-   *
-   * @return array
    */
   public function submit() {
     $isTest = ($this->_mode == 'test') ? 1 : 0;
@@ -1726,7 +1724,6 @@ class CRM_Member_Form_Membership extends CRM_Member_Form {
     $isRecur = CRM_Utils_Array::value('is_recur', $params);
     $this->updateContributionOnMembershipTypeChange($params, $membership);
     $this->setStatusMessage($membership, $endDate, $receiptSent, $membershipTypes, $createdMemberships, $isRecur, $calcDates, $mailSend);
-    return $createdMemberships;
   }
 
   /**