From: Eileen McNaughton <emcnaughton@wikimedia.org>
Date: Mon, 17 Jan 2022 21:34:37 +0000 (+1300)
Subject: Remove unused variable
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=38129a1d18b62344c7f8199e1a2c6e8afe62f125;p=civicrm-core.git

Remove unused variable

This is over-written a couple of lines later in the template so
we don't need it & ergo don't need to assign it either

Note that the paramter is assigned in postProcess for the
receipt so this is just this usage
---

diff --git a/CRM/Contribute/Form/Contribution.php b/CRM/Contribute/Form/Contribution.php
index 703ad29126..b7f1771797 100644
--- a/CRM/Contribute/Form/Contribution.php
+++ b/CRM/Contribute/Form/Contribution.php
@@ -516,11 +516,6 @@ class CRM_Contribute_Form_Contribution extends CRM_Contribute_Form_AbstractEditP
     $this->assign('payNow', FALSE);
     $buildRecurBlock = FALSE;
 
-    // display tax amount on edit contribution page
-    if ($invoicing && $this->_action & CRM_Core_Action::UPDATE && isset($this->_values['tax_amount'])) {
-      $this->assign('totalTaxAmount', $this->_values['tax_amount']);
-    }
-
     if (empty($this->_lineItems) &&
       ($this->_priceSetId || !empty($_POST['price_set_id']))
     ) {
diff --git a/templates/CRM/Contribute/Form/Contribution.tpl b/templates/CRM/Contribute/Form/Contribution.tpl
index 6bda33a8f5..e9d4c7885f 100644
--- a/templates/CRM/Contribute/Form/Contribution.tpl
+++ b/templates/CRM/Contribute/Form/Contribution.tpl
@@ -597,7 +597,6 @@
           // replace all thousandMarker and change the separator to a dot
           totalAmount = totalAmount.replace(thousandMarker,'').replace(separator,'.');
 
-          var totalTaxAmount = '{/literal}{$totalTaxAmount}{literal}';
           var taxAmount = (taxRate/100)*totalAmount;
           taxAmount = isNaN (taxAmount) ? 0:taxAmount;
           var totalTaxAmount = taxAmount + Number(totalAmount);