From: eileen <emcnaughton@wikimedia.org>
Date: Sat, 9 Nov 2019 01:12:20 +0000 (+1300)
Subject: Remove unhelpful alert from contribution search
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=33f5d7658cdf0e36f0a72dcab1110712dff49944;p=civicrm-core.git

Remove unhelpful alert from contribution search
---

diff --git a/CRM/Contribute/BAO/Query.php b/CRM/Contribute/BAO/Query.php
index 226544fc22..0d2462ae78 100644
--- a/CRM/Contribute/BAO/Query.php
+++ b/CRM/Contribute/BAO/Query.php
@@ -482,12 +482,6 @@ class CRM_Contribute_BAO_Query extends CRM_Core_BAO_Query {
         //all other elements are handle in this case
         $fldName = substr($name, 13);
         if (!isset($fields[$fldName])) {
-          // CRM-12597
-          CRM_Core_Session::setStatus(ts(
-              'We did not recognize the search field: %1. Please check and fix your contribution related smart groups.',
-              [1 => $fldName]
-            )
-          );
           return;
         }
         $whereTable = $fields[$fldName];
@@ -495,7 +489,7 @@ class CRM_Contribute_BAO_Query extends CRM_Core_BAO_Query {
           $value = trim($value);
         }
 
-        $dataType = "String";
+        $dataType = 'String';
         if (!empty($whereTable['type'])) {
           $dataType = CRM_Utils_Type::typeToString($whereTable['type']);
         }