From: Dan Fairs <dan@fezconsulting.com>
Date: Tue, 17 Jan 2012 12:17:33 +0000 (+0000)
Subject: Encode track and follow parameters to UTF8. Blindly calling str() will cause a Unicod... 
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=2d5db811a942262b6cd1b0c0d8ace712ac2b1a3a;p=tweepy.git

Encode track and follow parameters to UTF8. Blindly calling str() will cause a UnicodeEncodeError as the ascii codec is used.
---

diff --git a/tests/test_streaming.py b/tests/test_streaming.py
index fdeb2c9..ed4824b 100644
--- a/tests/test_streaming.py
+++ b/tests/test_streaming.py
@@ -68,6 +68,21 @@ class TweepyStreamTests(unittest.TestCase):
         self.assertEquals(self.listener.status_count,
                           self.listener.status_stop_count)
 
+    def test_track_encoding(self):
+        s = Stream(None, None)
+        s._start = lambda async: None
+        s.filter(track=[u'Caf\xe9'])
+
+        # Should be UTF-8 encoded
+        self.assertEqual(u'Caf\xe9'.encode('utf8'), s.parameters['track'])
+
+    def test_follow_encoding(self):
+        s = Stream(None, None)
+        s._start = lambda async: None
+        s.filter(follow=[u'Caf\xe9'])
+
+        # Should be UTF-8 encoded
+        self.assertEqual(u'Caf\xe9'.encode('utf8'), s.parameters['follow'])
 
 class TweepyStreamBackoffTests(unittest.TestCase):
     def setUp(self):
diff --git a/tweepy/streaming.py b/tweepy/streaming.py
index cd6bffb..61b3021 100644
--- a/tweepy/streaming.py
+++ b/tweepy/streaming.py
@@ -272,17 +272,19 @@ class Stream(object):
             self.url += '&count=%s' % count
         self._start(async)
 
-    def filter(self, follow=None, track=None, async=False, locations=None, 
-        count = None, stall_warnings=False, languages=None):
+    def filter(self, follow=None, track=None, async=False, locations=None,
+               count=None, stall_warnings=False, languages=None, encoding='utf8'):
         self.parameters = {}
         self.headers['Content-type'] = "application/x-www-form-urlencoded"
         if self.running:
             raise TweepError('Stream object already connected!')
         self.url = '/%s/statuses/filter.json?delimited=length' % STREAM_VERSION
         if follow:
-            self.parameters['follow'] = ','.join(map(str, follow))
+            encoded_follow = [s.encode(encoding) for s in follow]
+            self.parameters['follow'] = ','.join(encoded_follow)
         if track:
-            self.parameters['track'] = ','.join(map(str, track))
+            encoded_track = [s.encode(encoding) for s in track]
+            self.parameters['track'] = ','.join(encoded_track)
         if locations and len(locations) > 0:
             assert len(locations) % 4 == 0
             self.parameters['locations'] = ','.join(['%.2f' % l for l in locations])