From: Eileen McNaughton <emcnaughton@wikimedia.org>
Date: Mon, 17 May 2021 02:04:40 +0000 (+1200)
Subject: [REF] Fully remove ids variable from paypal std
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=2b4ab802e44c6a6491ac1235839bb60f4eba06c6;p=civicrm-core.git

[REF] Fully remove ids variable from paypal std

The ids variable is no longer used - bye
---

diff --git a/CRM/Core/Payment/PayPalIPN.php b/CRM/Core/Payment/PayPalIPN.php
index 1d15aa3f70..c0826c72b4 100644
--- a/CRM/Core/Payment/PayPalIPN.php
+++ b/CRM/Core/Payment/PayPalIPN.php
@@ -232,31 +232,18 @@ class CRM_Core_Payment_PayPalIPN extends CRM_Core_Payment_BaseIPN {
    */
   public function main() {
     try {
-      $ids = $input = [];
+      $input = [];
       $component = $this->retrieve('module', 'String');
       $input['component'] = $component;
 
-      $ids['contact'] = $this->getContactID();
-      $contributionID = $ids['contribution'] = $this->getContributionID();
+      $contributionID = $this->getContributionID();
       $membershipID = $this->retrieve('membershipID', 'Integer', FALSE);
 
       $this->getInput($input);
 
-      if ($component === 'event') {
-        $ids['event'] = $this->retrieve('eventID', 'Integer', TRUE);
-        $ids['participant'] = $this->retrieve('participantID', 'Integer', TRUE);
-      }
-      else {
-        // get the optional ids
-        $ids['membership'] = $membershipID;
-        $ids['contributionPage'] = $this->retrieve('contributionPageID', 'Integer', FALSE);
-        $ids['related_contact'] = $this->retrieve('relatedContactID', 'Integer', FALSE);
-        $ids['onbehalf_dupe_alert'] = $this->retrieve('onBehalfDupeAlert', 'Integer', FALSE);
-      }
-
       $paymentProcessorID = $this->getPayPalPaymentProcessorID($input, $this->getContributionRecurID());
 
-      Civi::log()->debug('PayPalIPN: Received (ContactID: ' . $ids['contact'] . '; trxn_id: ' . $input['trxn_id'] . ').');
+      Civi::log()->debug('PayPalIPN: Received (ContactID: ' . $this->getContactID() . '; trxn_id: ' . $input['trxn_id'] . ').');
 
       // Debugging related to possible missing membership linkage
       if ($this->getContributionRecurID() && $this->retrieve('membershipID', 'Integer', FALSE)) {