From: Eileen McNaughton Date: Sun, 3 May 2015 20:02:25 +0000 (+1200) Subject: CRM-16367 phpcs fixes X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=1ea0b4acd740d60cfdced75989b5bb383d5ce9fb;p=civicrm-core.git CRM-16367 phpcs fixes --- diff --git a/CRM/Contribute/Form/Contribution.php b/CRM/Contribute/Form/Contribution.php index 6f07b2c87d..712dd62a3c 100644 --- a/CRM/Contribute/Form/Contribution.php +++ b/CRM/Contribute/Form/Contribution.php @@ -1717,7 +1717,6 @@ class CRM_Contribute_Form_Contribution extends CRM_Contribute_Form_AbstractEditP } $params['non_deductible_amount'] = $this->calculateNonDeductibleAmount($params, $formValues); - $contribution = CRM_Contribute_BAO_Contribution::create($params, $ids); // process associated membership / participant, CRM-4395 diff --git a/tests/phpunit/CRM/Contribute/Form/ContributionTest.php b/tests/phpunit/CRM/Contribute/Form/ContributionTest.php index 3eedadc43b..3074235cbd 100644 --- a/tests/phpunit/CRM/Contribute/Form/ContributionTest.php +++ b/tests/phpunit/CRM/Contribute/Form/ContributionTest.php @@ -345,7 +345,7 @@ class CRM_Contribute_Form_ContributionTest extends CiviUnitTestCase { 'payment_instrument_id' => array_search('Check', $this->paymentInstruments), 'contribution_status_id' => 1, 'note' => 'Super cool and interesting stuff', - ) + $this->getCreditCardParams (), + ) + $this->getCreditCardParams(), CRM_Core_Action::ADD); $this->callAPISuccessGetCount('Contribution', array('contact_id' => $this->_individualId), 1); $note = $this->callAPISuccessGetSingle('note', array('entity_table' => 'civicrm_contribution')); @@ -358,7 +358,7 @@ class CRM_Contribute_Form_ContributionTest extends CiviUnitTestCase { * @return array * Credit card specific parameters. */ - function getCreditCardParams() { + protected function getCreditCardParams() { return array( 'payment_processor_id' => $this->paymentProcessor->id, 'credit_card_exp_date' => array('M' => 5, 'Y' => 2012),