From: eileen <emcnaughton@wikimedia.org>
Date: Mon, 6 Jun 2016 20:37:09 +0000 (-0600)
Subject: CRM-18701 tidy up, do not pass variables around as a reference when they are not... 
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=1a94de0a3dd613e47d996ee7a350f5e9371e25d9;p=civicrm-core.git

CRM-18701 tidy up, do not pass variables around as a reference when they are not being altered
---

diff --git a/CRM/Price/BAO/LineItem.php b/CRM/Price/BAO/LineItem.php
index 26c6495042..f13a13cee7 100644
--- a/CRM/Price/BAO/LineItem.php
+++ b/CRM/Price/BAO/LineItem.php
@@ -323,22 +323,18 @@ AND li.entity_id = {$entityId}
    * @param array $params
    *   Reference to form values.
    * @param array $fields
-   *   Reference to array of fields belonging.
+   *   Array of fields belonging.
    *                          to the price set used for particular event
    * @param array $values
    *   Reference to the values array(.
    *   this is
    *                          lineItem array)
-   *
-   * @return void
    */
-  public static function format($fid, &$params, &$fields, &$values) {
+  public static function format($fid, $params, $fields, &$values) {
     if (empty($params["price_{$fid}"])) {
       return;
     }
 
-    $optionIDs = implode(',', array_keys($params["price_{$fid}"]));
-
     //lets first check in fun parameter,
     //since user might modified w/ hooks.
     $options = array();