From: Coleman Watts <coleman@civicrm.org>
Date: Fri, 16 Dec 2016 20:32:21 +0000 (-0500)
Subject: CRM-19723 - Fix activity links
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=194b816856818da568ce0d03bbb531f0cbf36226;p=civicrm-core.git

CRM-19723 - Fix activity links
---

diff --git a/CRM/Activity/Form/ActivityLinks.php b/CRM/Activity/Form/ActivityLinks.php
index cddd1bbf3a..ef08fde392 100644
--- a/CRM/Activity/Form/ActivityLinks.php
+++ b/CRM/Activity/Form/ActivityLinks.php
@@ -57,7 +57,7 @@ class CRM_Activity_Form_ActivityLinks extends CRM_Core_Form {
 
     $activityTypes = array();
 
-    foreach ($allTypes as $id => $act) {
+    foreach ($allTypes as $act) {
       $url = 'civicrm/activity/add';
       if ($act['name'] == 'Email') {
         if (!CRM_Utils_Mail::validOutBoundMail() || !$contactId) {
@@ -93,7 +93,7 @@ class CRM_Activity_Form_ActivityLinks extends CRM_Core_Form {
         continue;
       }
       $act['url'] = CRM_Utils_System::url($url,
-        "{$urlParams}{$id}", FALSE, NULL, FALSE
+        "{$urlParams}{$act['value']}", FALSE, NULL, FALSE
       );
       $act += array('icon' => 'fa-plus-square-o');
       $activityTypes[$act['value']] = $act;