From: pdontthink <pdontthink@7612ce4b-ef26-0410-bec9-ea0150e637f0>
Date: Thu, 18 Dec 2008 01:10:59 +0000 (+0000)
Subject: Add notes about issue reported where unset() breaks when removing attachments
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=16449d847dee888173a803c26e8da69995fbe297;p=squirrelmail.git

Add notes about issue reported where unset() breaks when removing attachments

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@13369 7612ce4b-ef26-0410-bec9-ea0150e637f0
---

diff --git a/src/compose.php b/src/compose.php
index ee7130d1..f6c7a304 100644
--- a/src/compose.php
+++ b/src/compose.php
@@ -659,6 +659,8 @@ elseif (isset($sigappend)) {
         foreach($delete as $index) {
             if (!empty($composeMessage->entities) && isset($composeMessage->entities[$index])) {
                 $composeMessage->entities[$index]->purgeAttachments();
+                // FIXME: one person reported that unset() didn't do anything at all here, so this is a work-around... but it triggers PHP notices if the unset() doesn't work, which should be fixed... but bigger question is if unset() doesn't work here, what about everywhere else? Anyway, uncomment this if you think you need it
+                //$composeMessage->entities[$index] = NULL;
                 unset ($composeMessage->entities[$index]);
             }
         }