From: demeritcowboy <demeritcowboy@hotmail.com>
Date: Thu, 18 Mar 2021 02:49:41 +0000 (-0400)
Subject: remove loop that since at least 5.23 does nothing for single cases and crashes for... 
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=09632ed39a2d5816ebb7015746414bb47c9a9759;p=civicrm-core.git

remove loop that since at least 5.23 does nothing for single cases and crashes for multiple, and for multiple recipients only uses the last activity id for 5.36+
---

diff --git a/CRM/Contact/Form/Task/EmailTrait.php b/CRM/Contact/Form/Task/EmailTrait.php
index 67c06172d8..bd5c205996 100644
--- a/CRM/Contact/Form/Task/EmailTrait.php
+++ b/CRM/Contact/Form/Task/EmailTrait.php
@@ -447,20 +447,6 @@ trait CRM_Contact_Form_Task_EmailTrait {
         'plural' => '%count Messages Not Sent',
       ]), 'info');
     }
-
-    if (isset($this->_caseId)) {
-      // if case-id is found in the url, create case activity record
-      $cases = explode(',', $this->_caseId);
-      foreach ($cases as $key => $val) {
-        if (is_numeric($val)) {
-          $caseParams = [
-            'activity_id' => $activityId,
-            'case_id' => $val,
-          ];
-          CRM_Case_BAO_Case::processCaseActivity($caseParams);
-        }
-      }
-    }
   }
 
   /**