From: Aleksandar Micovic <aleks.micovic@gmail.com>
Date: Fri, 3 Jun 2011 01:07:37 +0000 (-0400)
Subject: Refactored the sending of verification emails.
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=02d80437d1cdda5b2a8596d024aafa8b286cb360;p=mediagoblin.git

Refactored the sending of verification emails.
---

diff --git a/mediagoblin/auth/lib.py b/mediagoblin/auth/lib.py
index 7cf021bc..dc5f9941 100644
--- a/mediagoblin/auth/lib.py
+++ b/mediagoblin/auth/lib.py
@@ -19,6 +19,9 @@ import random
 
 import bcrypt
 
+from mediagoblin.util import send_email
+from mediagoblin import globals as mgoblin_globals
+
 
 def bcrypt_check_password(raw_pass, stored_hash, extra_salt=None):
     """
@@ -84,3 +87,34 @@ def fake_login_attempt():
     randplus_hashed_pass = bcrypt.hashpw(hashed_pass, rand_salt)
 
     randplus_stored_hash == randplus_hashed_pass
+
+
+def send_verification_email(user, request):
+    """
+    Send the verification email to users to activate their accounts.
+
+    Args:
+    - user: a user object
+    - request: the request 
+    """
+
+    email_template = request.template_env.get_template(
+        'mediagoblin/auth/verification_email.txt')
+
+    # TODO: There is no error handling in place
+    send_email(
+        mgoblin_globals.email_sender_address,
+        [user['email']],
+        # TODO
+        # Due to the distributed nature of GNU MediaGoblin, we should
+        # find a way to send some additional information about the 
+        # specific GNU MediaGoblin instance in the subject line. For 
+        # example "GNU MediaGoblin @ Wandborg - [...]".   
+        'GNU MediaGoblin - Verify your email!',
+        email_template.render(
+            username=user['username'],
+            verification_url='http://{host}{uri}?userid={userid}&token={verification_key}'.format(
+            host=request.host,
+            uri=request.urlgen('mediagoblin.auth.verify_email'),
+            userid=unicode(user['_id']),
+            verification_key=user['verification_key'])))
diff --git a/mediagoblin/auth/views.py b/mediagoblin/auth/views.py
index 948db188..e4f1a7b1 100644
--- a/mediagoblin/auth/views.py
+++ b/mediagoblin/auth/views.py
@@ -21,8 +21,7 @@ from webob import Response, exc
 from mediagoblin.db.util import ObjectId
 from mediagoblin.auth import lib as auth_lib
 from mediagoblin.auth import forms as auth_forms
-from mediagoblin.util import send_email
-from mediagoblin import globals as mgoblin_globals
+from mediagoblin.auth.lib import send_verification_email
 
 
 def register(request):
@@ -52,27 +51,8 @@ def register(request):
                 request.POST['password'])
             entry.save(validate=True)
             
-            email_template = request.template_env.get_template(
-                'mediagoblin/auth/verification_email.txt')
-
-            # TODO: There is no error handling in place
-            send_email(
-                mgoblin_globals.email_sender_address,
-                [entry['email']],
-                # TODO
-                # Due to the distributed nature of GNU MediaGoblin, we should
-                # find a way to send some additional information about the 
-                # specific GNU MediaGoblin instance in the subject line. For 
-                # example "GNU MediaGoblin @ Wandborg - [...]".   
-                'GNU MediaGoblin - Verify email',
-                email_template.render(
-                    username=entry['username'],
-                    verification_url='http://{host}{uri}?userid={userid}&token={verification_key}'.format(
-                        host=request.host,
-                        uri=request.urlgen('mediagoblin.auth.verify_email'),
-                        userid=unicode(entry['_id']),
-                        verification_key=entry['verification_key'])))
-            
+            send_verification_email(entry, request)
+
             # Redirect to register_success
             return exc.HTTPFound(
                 location=request.urlgen("mediagoblin.auth.register_success"))
@@ -195,31 +175,11 @@ def resend_activation(request):
 
     Resend the activation email.
     """
+
     request.user['verification_key'] = unicode(uuid.uuid4())
     request.user.save()
 
-    # Copied shamelessly from the register view above.
-
-    email_template = request.template_env.get_template(
-        'mediagoblin/auth/verification_email.txt')
-
-    # TODO: There is no error handling in place
-    send_email(
-        mgoblin_globals.email_sender_address,
-        [request.user['email']],
-        # TODO
-        # Due to the distributed nature of GNU MediaGoblin, we should
-        # find a way to send some additional information about the 
-        # specific GNU MediaGoblin instance in the subject line. For 
-        # example "GNU MediaGoblin @ Wandborg - [...]".   
-        'GNU MediaGoblin - Verify email',
-        email_template.render(
-            username=request.user['username'],
-            verification_url='http://{host}{uri}?userid={userid}&token={verification_key}'.format(
-                host=request.host,
-                uri=request.urlgen('mediagoblin.auth.verify_email'),
-                userid=unicode(request.user['_id']),
-                verification_key=request.user['verification_key'])))
+    send_verification_email(request.user, request)
 
     return exc.HTTPFound(
         location=request.urlgen('mediagoblin.auth.resend_verification_success'))