From: Eileen McNaughton <emcnaughton@wikimedia.org>
Date: Fri, 28 Oct 2022 00:02:31 +0000 (+1300)
Subject: Remove notice-causing do-nothing script
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=01f9aa8d5c218d97857281e87302a633e3ce2080;p=civicrm-core.git

Remove notice-causing do-nothing script

In my UI testing & code delving I couldn't see how hiding 'extends_1' was
doing anything. The field didn't seem to be on the page
and the 'extends' files were not hidden....
---

diff --git a/CRM/Custom/Form/Group.php b/CRM/Custom/Form/Group.php
index 46dde5f9b2..be0ac00fdd 100644
--- a/CRM/Custom/Form/Group.php
+++ b/CRM/Custom/Form/Group.php
@@ -181,15 +181,6 @@ class CRM_Custom_Form_Group extends CRM_Core_Form {
       }
     }
 
-    if (!isset($this->_id)) {
-      $formName = 'document.forms.' . $this->_name;
-
-      $js = "<script type='text/javascript'>\n";
-      $js .= "{$formName}['extends_1'].style.display = 'none';\n";
-      $js .= "</script>";
-      $this->assign('initHideBlocks', $js);
-    }
-
     $sel = &$this->add('hierselect',
       'extends',
       ts('Used For'),
diff --git a/templates/CRM/Custom/Form/Group.tpl b/templates/CRM/Custom/Form/Group.tpl
index d97e4df478..da3d1178eb 100644
--- a/templates/CRM/Custom/Form/Group.tpl
+++ b/templates/CRM/Custom/Form/Group.tpl
@@ -73,7 +73,7 @@
       {crmButton p='civicrm/admin/custom/group/field' q="action=browse&reset=1&gid=$gid" icon="th-list"}{ts}Custom Fields for this Set{/ts}{/crmButton}
     </div>
 {/if}
-{if !empty($initHideBlocks|smarty:nodefaults)}{$initHideBoxes|smarty:nodefaults}{/if}
+
 {literal}
 <script type="text/Javascript">
 CRM.$(function($) {
@@ -102,7 +102,7 @@ CRM.$(function($) {
   function showHideStyle() {
     var
       extend = $(this).val(),
-      contactTypes = {/literal}{$contactTypes}{literal},
+      contactTypes = {/literal}{$contactTypes|smarty:nodefaults}{literal},
       showStyle = "{/literal}{$showStyle}{literal}",
       showMultiple = "{/literal}{$showMultiple}{literal}",
       showMaxMultiple = "{/literal}{$showMaxMultiple}{literal}",