From: eileenmcnaugton <emcnaughton@wikimedia.org>
Date: Fri, 10 May 2019 08:55:47 +0000 (+1200)
Subject: Update testGetActivityAccessCiviCRMEnough test for clarity
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=00e2484dc934f8ebb2d23365cf5b6fc2bcb58caf;p=civicrm-core.git

Update testGetActivityAccessCiviCRMEnough test for clarity
---

diff --git a/tests/phpunit/api/v3/ACLPermissionTest.php b/tests/phpunit/api/v3/ACLPermissionTest.php
index f72b0a8818..ff7534ff28 100644
--- a/tests/phpunit/api/v3/ACLPermissionTest.php
+++ b/tests/phpunit/api/v3/ACLPermissionTest.php
@@ -571,15 +571,19 @@ class api_v3_ACLPermissionTest extends CiviUnitTestCase {
   }
 
   /**
-   * View all activities is required unless id is passed in, in which case ACLs are used.
+   * Check the error message is not a permission error.
    */
-  public function testGetActivityAccessCiviCRMNotEnough() {
+  public function testGetActivityAccessCiviCRMEnough() {
     $activity = $this->activityCreate();
     $this->setPermissions(['access CiviCRM']);
     $this->callAPIFailure('Activity', 'getsingle', [
       'check_permissions' => 1,
       'id' => $activity['id'],
-    ]);
+    ], 'Expected one Activity but found 0');
+    $this->callAPISuccessGetCount('Activity', [
+      'check_permissions' => 1,
+      'id' => $activity['id'],
+    ], 0);
   }
 
   /**