[NFC] CRM-19033 improve standardisation of tests

NB jenkins is doing wierd things here so trying a small subset to see what jenkins does

Change-Id: Ia4d74eeddff5ea159fbbb4eead9da6ec42028d00

diff --git a/CRM/Member/BAO/Membership.php b/CRM/Member/BAO/Membership.php
index fabd1cc20701663806efc52a6b85dc44543c16ba..8789a02ef77dd6115b69613d45665d1a3e425443 100644 (file)
--- a/CRM/Member/BAO/Membership.php
+++ b/CRM/Member/BAO/Membership.php
@@ -1308,7 +1308,7 @@ FROM   civicrm_membership, civicrm_contact
 WHERE  civicrm_membership.contact_id = civicrm_contact.id
   AND  civicrm_membership.id = {$id}
 ";
-    return CRM_Core_DAO::singleValueQuery($query, CRM_Core_DAO::$_nullArray);
+    return CRM_Core_DAO::singleValueQuery($query);
   }
 
   /**

diff --git a/tests/phpunit/CRM/Activity/BAO/ActivityTest.php b/tests/phpunit/CRM/Activity/BAO/ActivityTest.php
index 18d949b8a7ee2e207f3c03afd4a6a1a3cecda38f..8643953b3fb8e49412ed5dcb67dece99a7be08d3 100644 (file)
--- a/tests/phpunit/CRM/Activity/BAO/ActivityTest.php
+++ b/tests/phpunit/CRM/Activity/BAO/ActivityTest.php
@@ -21,7 +21,7 @@ class CRM_Activity_BAO_ActivityTest extends CiviUnitTestCase {
    * Test case for create() method.
    */
   public function testCreate() {
-    $contactId = Contact::createIndividual();
+    $contactId = $this->individualCreate();
 
     $params = array(
       'source_contact_id' => $contactId,
@@ -61,12 +61,12 @@ class CRM_Activity_BAO_ActivityTest extends CiviUnitTestCase {
    * getContactActivity() method get activities detail for given target contact id.
    */
   public function testGetContactActivity() {
-    $contactId = Contact::createIndividual();
+    $contactId = $this->individualCreate();
     $params = array(
       'first_name' => 'liz',
       'last_name' => 'hurleey',
     );
-    $targetContactId = Contact::createIndividual($params);
+    $targetContactId = $this->individualCreate($params);
 
     $params = array(
       'source_contact_id' => $contactId,
@@ -76,7 +76,7 @@ class CRM_Activity_BAO_ActivityTest extends CiviUnitTestCase {
       'activity_date_time' => date('Ymd'),
     );
 
-    CRM_Activity_BAO_Activity::create($params);
+    $this->callAPISuccess('Activity', 'create', $params);
 
     $activityId = $this->assertDBNotNull('CRM_Activity_DAO_Activity', 'Scheduling Meeting',
       'id',
@@ -98,12 +98,12 @@ class CRM_Activity_BAO_ActivityTest extends CiviUnitTestCase {
    *                              and set defaults.
    */
   public function testRetrieve() {
-    $contactId = Contact::createIndividual();
+    $contactId = $this->individualCreate();
     $params = array(
       'first_name' => 'liz',
       'last_name' => 'hurleey',
     );
-    $targetContactId = Contact::createIndividual($params);
+    $targetContactId = $this->individualCreate($params);
 
     $params = array(
       'source_contact_id' => $contactId,
@@ -146,12 +146,12 @@ class CRM_Activity_BAO_ActivityTest extends CiviUnitTestCase {
    * deleteActivity($params) method deletes activity for given params.
    */
   public function testDeleteActivity() {
-    $contactId = Contact::createIndividual();
+    $contactId = $this->individualCreate();
     $params = array(
       'first_name' => 'liz',
       'last_name' => 'hurleey',
     );
-    $targetContactId = Contact::createIndividual($params);
+    $targetContactId = $this->individualCreate($params);
 
     $params = array(
       'source_contact_id' => $contactId,
@@ -194,12 +194,12 @@ class CRM_Activity_BAO_ActivityTest extends CiviUnitTestCase {
    * deleteActivityTarget($activityId) method deletes activity target for given activity id.
    */
   public function testDeleteActivityTarget() {
-    $contactId = Contact::createIndividual();
+    $contactId = $this->individualCreate();
     $params = array(
       'first_name' => 'liz',
       'last_name' => 'hurleey',
     );
-    $targetContactId = Contact::createIndividual($params);
+    $targetContactId = $this->individualCreate($params);
 
     $params = array(
       'source_contact_id' => $contactId,
@@ -236,12 +236,12 @@ class CRM_Activity_BAO_ActivityTest extends CiviUnitTestCase {
    * deleteActivityAssignment($activityId) method deletes activity assignment for given activity id.
    */
   public function testDeleteActivityAssignment() {
-    $contactId = Contact::createIndividual();
+    $contactId = $this->individualCreate();
     $params = array(
       'first_name' => 'liz',
       'last_name' => 'hurleey',
     );
-    $assigneeContactId = Contact::createIndividual($params);
+    $assigneeContactId = $this->individualCreate($params);
 
     $params = array(
       'source_contact_id' => $contactId,