projects
/
civicrm-core.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
64338ae
)
[REF] do not receive by reference in CustomField::create
author
eileen
<emcnaughton@wikimedia.org>
Fri, 28 Jun 2019 22:43:33 +0000
(10:43 +1200)
committer
eileen
<emcnaughton@wikimedia.org>
Fri, 28 Jun 2019 22:43:33 +0000
(10:43 +1200)
I audited the places where this is called in core and the object is not later interogated for changes
CRM/Core/BAO/CustomField.php
patch
|
blob
|
blame
|
history
diff --git
a/CRM/Core/BAO/CustomField.php
b/CRM/Core/BAO/CustomField.php
index 308cde26d358b3cab65b0b6818354e5aabd588c0..a6e839cbe980df8e786277974ebfa0c93bb1879a 100644
(file)
--- a/
CRM/Core/BAO/CustomField.php
+++ b/
CRM/Core/BAO/CustomField.php
@@
-151,7
+151,7
@@
class CRM_Core_BAO_CustomField extends CRM_Core_DAO_CustomField {
*
* @return CRM_Core_DAO_CustomField
*/
- public static function create(
&
$params) {
+ public static function create($params) {
$origParams = array_merge(array(), $params);
$op = empty($params['id']) ? 'create' : 'edit';