Use name instead of label to check contribution status
authorMatthew Wire (MJW Consulting) <mjw@mjwconsult.co.uk>
Wed, 2 Oct 2019 15:42:07 +0000 (16:42 +0100)
committerMatthew Wire (MJW Consulting) <mjw@mjwconsult.co.uk>
Wed, 2 Oct 2019 15:42:07 +0000 (16:42 +0100)
CRM/Contribute/Form/Contribution/Confirm.php

index 8f7e170fddb1609ba710796344c9066caf9ca530..3a7afb414a3785d0d0baaf488b7e1a1eb8144127 100644 (file)
@@ -1554,7 +1554,7 @@ class CRM_Contribute_Form_Contribution_Confirm extends CRM_Contribute_Form_Contr
 
         // @todo Move this into CRM_Member_BAO_Membership::processMembership
         if (!empty($membershipContribution)) {
-          $pending = ($membershipContribution->contribution_status_id == array_search('Pending', CRM_Contribute_PseudoConstant::contributionStatus())) ? TRUE : FALSE;
+          $pending = ($membershipContribution->contribution_status_id == CRM_Core_PseudoConstant::getKey('CRM_Contribute_BAO_Contribution', 'contribution_status_id', 'Pending')) ? TRUE : FALSE;
         }
         else {
           $pending = $this->getIsPending();