fixing typos and refactoring on isVisible()

diff --git a/CRM/Utils/Check/Message.php b/CRM/Utils/Check/Message.php
index 0b76d8ad88b8bd6d5c5ab0997ed55398e3ada453..a49187560fa6734094c23927f637d2b65381812a 100644 (file)
--- a/CRM/Utils/Check/Message.php
+++ b/CRM/Utils/Check/Message.php
@@ -150,7 +150,7 @@ class CRM_Utils_Check_Message {
     return $array;
   }
 
-  public function isVisibile() {
+  public function isVisible() {
     return $this->isVisible;
   }
 

diff --git a/api/v3/System.php b/api/v3/System.php
index 2017d5a6fa78f966baa6ef9251f816a4a75784a8..76ee3eba1ca7c30ec5e9aa8fe3b75fc7f7470a22 100644 (file)
--- a/api/v3/System.php
+++ b/api/v3/System.php
@@ -103,13 +103,17 @@ function _civicrm_api3_system_check_spec(&$spec) {
  * @throws API_Exception
  */
 function civicrm_api3_system_check($params) {
+  // array(array('name'=> $, 'severity'=>$, ...))
   $returnValues = array();
+
+  // array(CRM_Utils_Check_Message)
   $messages = CRM_Utils_Check::singleton()->checkAll();
+
   $showHushed = CRM_Utils_Array::value('show_hushed', $params);
   if (!$showHushed) {
     foreach ($messages as $key => $message) {
-      if (!$message->isVisible()) {
-        unset($messages[$key]);
+      if ($message->isVisible()) {
+        $returnValues[] = $message->toArray();
       }
     }
   }