Fix serialized membership field handling in RelationshipTest

These fields were being unnecessarily and incorrectly serialized by the test.
Passing an array is preferred and it will handle the serialization correctly.

diff --git a/tests/phpunit/api/v3/RelationshipTest.php b/tests/phpunit/api/v3/RelationshipTest.php
index cde14d283d90e0a1c2a109f51909c2e4300176b5..783322f6944fe3e2a36e54bcdece4d31a43cd3da 100644 (file)
--- a/tests/phpunit/api/v3/RelationshipTest.php
+++ b/tests/phpunit/api/v3/RelationshipTest.php
@@ -1183,8 +1183,8 @@ class api_v3_RelationshipTest extends CiviUnitTestCase {
     $relType3 = 6;
     $relType1 = 1;
     $memberType = $this->membershipTypeCreate([
-      'relationship_type_id' => CRM_Core_DAO::VALUE_SEPARATOR . $relType1 . CRM_Core_DAO::VALUE_SEPARATOR . $relType3 . CRM_Core_DAO::VALUE_SEPARATOR,
-      'relationship_direction' => CRM_Core_DAO::VALUE_SEPARATOR . 'a_b' . CRM_Core_DAO::VALUE_SEPARATOR . 'b_a' . CRM_Core_DAO::VALUE_SEPARATOR,
+      'relationship_type_id' => [$relType1, $relType3],
+      'relationship_direction' => ['a_b', 'b_a'],
     ]);
 
     // Relationship 2.
@@ -1242,8 +1242,8 @@ class api_v3_RelationshipTest extends CiviUnitTestCase {
     $relType3 = 6;
     $relType1 = 1;
     $memberType = $this->membershipTypeCreate([
-      'relationship_type_id' => CRM_Core_DAO::VALUE_SEPARATOR . $relType1 . CRM_Core_DAO::VALUE_SEPARATOR . $relType3 . CRM_Core_DAO::VALUE_SEPARATOR,
-      'relationship_direction' => CRM_Core_DAO::VALUE_SEPARATOR . 'a_b' . CRM_Core_DAO::VALUE_SEPARATOR . 'b_a' . CRM_Core_DAO::VALUE_SEPARATOR,
+      'relationship_type_id' => [$relType1, $relType3],
+      'relationship_direction' => ['a_b', 'b_a'],
     ]);
 
     // Relationship 2.