Remove attempt to load contriution id from invoiceID
authoreileen <emcnaughton@wikimedia.org>
Wed, 3 Feb 2021 01:38:49 +0000 (14:38 +1300)
committereileen <emcnaughton@wikimedia.org>
Wed, 3 Feb 2021 01:39:50 +0000 (14:39 +1300)
This might make sense (maybe) on the front end code this was previously shared with but on the
backoffice form id would be specifically set in the url

CRM/Member/Form/Membership.php

index c3561abea10c5a20193e347dd121337341c9edc9..0d1306338629b2808cab7ccb72a19be88307b199 100644 (file)
@@ -1897,14 +1897,6 @@ DESC limit 1");
       }
 
       $contributionParams['contribution_status_id'] = CRM_Core_PseudoConstant::getKey('CRM_Contribute_BAO_Contribution', 'contribution_status_id', 'Pending');
-      if (isset($contributionParams['invoice_id'])) {
-        $contributionParams['id'] = CRM_Core_DAO::getFieldValue(
-          'CRM_Contribute_DAO_Contribution',
-          $contributionParams['invoice_id'],
-          'id',
-          'invoice_id'
-        );
-      }
 
       $contributionParams['skipCleanMoney'] = TRUE;
       // @todo this is the wrong place for this - it should be done as close to form submission