Redundant MediaMessages caching
authorDarren <darren@Darrens-MacBook-Pro.local>
Sat, 25 May 2013 15:03:50 +0000 (16:03 +0100)
committerDarren <darren@Darrens-MacBook-Pro.local>
Sat, 25 May 2013 15:03:50 +0000 (16:03 +0100)
client/assets/src/views/panel.js

index 7200d00dd6e0e818688b6dd60a3892707a5363ba..5ecba801d88820826f4313ae5ee54b335d170150 100644 (file)
@@ -179,11 +179,11 @@ _kiwi.view.Panel = Backbone.View.extend({
             media_message = $media.data('media');
         } else {
             media_message = new _kiwi.view.MediaMessage({el: $media[0]});
+
+            // Cache this MediaMessage instance for when it's opened again
             $media.data('media', media_message);
         }
 
-        $media.data('media', media_message);
-
         media_message.open();
     },