Add comments to relate to gitlab ticket
authorMatthew Wire (MJW Consulting) <mjw@mjwconsult.co.uk>
Fri, 23 Aug 2019 23:16:03 +0000 (00:16 +0100)
committerMatthew Wire (MJW Consulting) <mjw@mjwconsult.co.uk>
Fri, 23 Aug 2019 23:16:03 +0000 (00:16 +0100)
CRM/Contribute/BAO/Contribution.php
CRM/Contribute/BAO/ContributionRecur.php

index 9dcc2224c29dfbb08ca57a731c078bd97b6705b4..0d5fdf0520a203b8c40dce0123e9d1d2192c1217 100644 (file)
@@ -1016,6 +1016,7 @@ class CRM_Contribute_BAO_Contribution extends CRM_Contribute_DAO_Contribution {
    * @return array
    */
   protected static function cancel($processContributionObject, $memberships, $contributionId, $membershipStatuses, $updateResult, $participant, $oldStatus, $pledgePayment, $pledgeID, $pledgePaymentIDs, $contributionStatusId) {
+    // @fixme https://lab.civicrm.org/dev/core/issues/927 Cancelling membership etc is not desirable for all use-cases and we should be able to disable it
     $processContribution = FALSE;
     $participantStatuses = CRM_Event_PseudoConstant::participantStatus();
     if (is_array($memberships)) {
index c6197f14cef709f1d8b9da6bcc574018e48a25f0..233377eb157f9c29984fbc23b22bf1aed276822b 100644 (file)
@@ -284,6 +284,7 @@ class CRM_Contribute_BAO_ContributionRecur extends CRM_Contribute_DAO_Contributi
       $recur->cancel_date = date('YmdHis');
       $recur->save();
 
+      // @fixme https://lab.civicrm.org/dev/core/issues/927 Cancelling membership etc is not desirable for all use-cases and we should be able to disable it
       $dao = CRM_Contribute_BAO_ContributionRecur::getSubscriptionDetails($recurId);
       if ($dao && $dao->recur_id) {
         $details = CRM_Utils_Array::value('details', $activityParams);