[NFC] Minor cleanup, return preferred parameter
authoreileen <emcnaughton@wikimedia.org>
Sun, 7 Oct 2018 10:54:25 +0000 (11:54 +0100)
committereileen <emcnaughton@wikimedia.org>
Sun, 7 Oct 2018 10:54:30 +0000 (11:54 +0100)
The result parameter is the same as $recurring (save()) returns $this. But
it's more correct to return $recurring than result as
a) it's defined as a Contribute_BAO_ContributionRecur object which is correct.
b) it's the object passed through hooks

CRM/Contribute/BAO/ContributionRecur.php

index a5c76722c4339cca4753afcb0dd3edf417270dbc..89ed90f7a6a0ca7ad1c6c8558617f16fdcc46301 100644 (file)
@@ -96,7 +96,7 @@ class CRM_Contribute_BAO_ContributionRecur extends CRM_Contribute_DAO_Contributi
       $config = CRM_Core_Config::singleton();
       $recurring->currency = $config->defaultCurrency;
     }
-    $result = $recurring->save();
+    $recurring->save();
 
     if (!empty($params['id'])) {
       CRM_Utils_Hook::post('edit', 'ContributionRecur', $recurring->id, $recurring);
@@ -111,7 +111,7 @@ class CRM_Contribute_BAO_ContributionRecur extends CRM_Contribute_DAO_Contributi
       CRM_Core_BAO_CustomValueTable::store($params['custom'], 'civicrm_contribution_recur', $recurring->id);
     }
 
-    return $result;
+    return $recurring;
   }
 
   /**