[Ref] Simplify IF clause

This if is only reached if contributionStatus is completed - ergo it can't be anything else - poof.

Also previousStatus will be empty if previous_status_id is not set - so the in_array(previousStatus)
check is enough

diff --git a/CRM/Contribute/BAO/Contribution.php b/CRM/Contribute/BAO/Contribution.php
index 3093761de99aa776e6196a01f65bcf7749a9e631..0018c801ba1205c658604906dcbc4a97d1f167d6 100644 (file)
--- a/CRM/Contribute/BAO/Contribution.php
+++ b/CRM/Contribute/BAO/Contribution.php
@@ -2090,9 +2090,6 @@ LEFT JOIN  civicrm_contribution contribution ON ( componentPayment.contribution_
     $contributionId = $params['contribution_id'];
     $contributionStatusId = $params['contribution_status_id'];
 
-    // if we already processed contribution object pass previous status id.
-    $previousContriStatusId = $params['previous_contribution_status_id'];
-
     // we process only ( Completed, Cancelled, or Failed ) contributions.
     if (!$contributionId || $contributionStatus !== 'Completed') {
       return;
@@ -2169,24 +2166,10 @@ LEFT JOIN  civicrm_contribution contribution ON ( componentPayment.contribution_
     if ($contributionStatus === 'Completed') {
 
       // only pending contribution related object processed.
-      if ($previousContriStatusId &&
-        !in_array($previousStatus, [
-          'Pending',
-          'Partially paid',
-        ])
-      ) {
+      if (!in_array($previousStatus, ['Pending', 'Partially paid'])) {
         // this is case when we already processed contribution object.
         return;
       }
-      elseif (!$previousContriStatusId &&
-        !in_array($contributionStatus, [
-          'Pending',
-          'Partially paid',
-        ])
-      ) {
-        // this is case when we are going to process contribution object later.
-        return;
-      }
 
       if (is_array($memberships)) {
         foreach ($memberships as $membership) {