Remove duplicated code and add a note about what this is all about

diff --git a/CRM/Contribute/Form/Task/PDF.php b/CRM/Contribute/Form/Task/PDF.php
index 6c064d0cb39cd88fec5f6f1dd013e0aec10be1b2..d4c111cdb764532cf8623297672b343f23f576d6 100644 (file)
--- a/CRM/Contribute/Form/Task/PDF.php
+++ b/CRM/Contribute/Form/Task/PDF.php
@@ -154,10 +154,6 @@ AND    {$this->_componentClause}";
     $params = $this->controller->exportValues($this->_name);
     $elements = self::getElements($this->_contributionIds, $params, $this->_contactIds);
 
-    $fromEmail = $params['fromEmailAddress'];
-    $from = CRM_Utils_Array::value($fromEmail, $this->_emails);
-    $fromDetails = explode(' <', $from);
-
     foreach ($elements['details'] as $contribID => $detail) {
       $input = $ids = $objects = array();
 
@@ -201,6 +197,7 @@ AND    {$this->_componentClause}";
 
       $values = array();
       if (isset($params['fromEmailAddress']) && !$elements['createPdf']) {
+        // CRM-19129 Allow useres the choice of From Email to send the receipt from.
         $fromEmail = $params['fromEmailAddress'];
         $from = CRM_Utils_Array::value($fromEmail, $this->_emails);
         $fromDetails = explode(' <', $from);