Add reminder comments that someone needs to take a look and fix some code in this...

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12406 7612ce4b-ef26-0410-bec9-ea0150e637f0

diff --git a/functions/template/general_util.php b/functions/template/general_util.php
index 1711c15537a220a4bdbff6bfc8ae863a602f3d71..c54be4aef9be8ec6768c9ba805ce8a6c2555ec73 100644 (file)
--- a/functions/template/general_util.php
+++ b/functions/template/general_util.php
@@ -130,14 +130,17 @@ function getIconPath ($icon_theme_path, $icon_name) {
         return NULL;
 
     // Desired icon exists in the current theme?
+//FIXME: this assumes a URI path will be valid when used as a filesystem path - this will fail for some systems -- OTOH, if $icon_theme_path is meant as an internal filesystem path to the user's chosen theme directory, then the assumption that is wrong here is that this internal filesystem path is always correct for use as part of a URI.  This really should be mapped to/from an internal path to a URI path -- or can we guarantee that the two are always the same?
     if (is_file($icon_theme_path . $icon_name)) {
         return $icon_theme_path . $icon_name;
 
     // Icon not found, check for the admin-specified fallback
+//FIXME: same problem here as above
     } elseif (!is_null($fallback_icon_theme_path) && is_file($fallback_icon_theme_path . $icon_name)) {
         return $fallback_icon_theme_path . $icon_name;
 
     // Icon not found, return the SQM default icon
+//FIXME: same problem here -- SM_PATH is *NOT* intended for use in URIs
     } elseif (is_file(SM_PATH . 'images/themes/default/'.$icon_name)) {
         return SM_PATH . 'images/themes/default/'.$icon_name;
     }