Deprecate probably never true condition

If we can clarify that price set is ALWAYS set it will simplify stuff
- comments suggest that the exception has been weird test config

diff --git a/CRM/Contribute/Form/ContributionBase.php b/CRM/Contribute/Form/ContributionBase.php
index c993912f98c671c9dbc9ca307e71104d09531116..2fee4a089a178bef72466b10743408ff9c47ca4e 100644 (file)
--- a/CRM/Contribute/Form/ContributionBase.php
+++ b/CRM/Contribute/Form/ContributionBase.php
@@ -360,6 +360,9 @@ class CRM_Contribute_Form_ContributionBase extends CRM_Core_Form {
       $this->order = new CRM_Financial_BAO_Order();
       $this->order->setPriceSetID($this->getPriceSetID());
     }
+    else {
+      CRM_Core_Error::deprecatedFunctionWarning('forms require a price set it');
+    }
     $this->_priceSet = $this->get('priceSet');
 
     if (!$this->_values) {