the experiment that @colemanw suggested: reject non-array $list param

diff --git a/CRM/Utils/Array.php b/CRM/Utils/Array.php
index b96b4bbc63e69e8f2ebec8dfd29e531a75fd8ea5..3045fb38fefa87410f375882fc877634d41c9ed7 100644 (file)
--- a/CRM/Utils/Array.php
+++ b/CRM/Utils/Array.php
@@ -70,8 +70,8 @@ class CRM_Utils_Array {
     if ($list instanceof ArrayAccess) {
       return $list->offsetExists($key) ? $list[$key] : $default;
     }
-    // @todo - eliminate these from core & uncomment this line.
-    // CRM_Core_Error::deprecatedFunctionWarning('You have passed an invalid parameter for the "list"');
+    // @todo - eliminate invalid usages from core & uncomment this line.
+    CRM_Core_Error::deprecatedFunctionWarning('an array/ArrayAccess for the "list" parameter');
     return $default;
   }