CRM-151: Allow to Edit Recurring Contributions From Membership
authorCamilo Rodriguez <camilo@compucorp.co.uk>
Tue, 29 May 2018 18:12:32 +0000 (18:12 +0000)
committerCamilo Rodriguez <camilo@compucorp.co.uk>
Wed, 20 Jun 2018 16:54:14 +0000 (16:54 +0000)
A check for payment processor id was causing all recurring contributions shown
on membership details view to never show the 'Edit' action, as this value was
not availble. Fixed by removing check, as it is no longer required.

CRM/Member/Page/RecurringContributions.php

index 67ef43d1d2ccb82774bd158f705e99620b82557d..67b2b93938145ab593879302bde2485075ddf8f9 100644 (file)
@@ -112,14 +112,18 @@ class CRM_Member_Page_RecurringContributions extends CRM_Core_Page {
    */
   private function setActionsForRecurringContribution($recurID, &$recurringContribution) {
     $action = array_sum(array_keys($this->recurLinks($recurID)));
+
     // no action allowed if it's not active
     $recurringContribution['is_active'] = ($recurringContribution['contribution_status_id'] != 3);
+
     if ($recurringContribution['is_active']) {
       $details = CRM_Contribute_BAO_ContributionRecur::getSubscriptionDetails($recurringContribution['id'], 'recur');
       $hideUpdate = $details->membership_id & $details->auto_renew;
-      if ($hideUpdate || empty($details->processor_id)) {
+
+      if ($hideUpdate) {
         $action -= CRM_Core_Action::UPDATE;
       }
+
       $recurringContribution['action'] = CRM_Core_Action::formLink(
         $this->recurLinks($recurID),
         $action,