One less look up as suggested

CRM-20311 - Membership cancelation via contribution activity

----------------------------------------
* CRM-20311: Membership cancelation via contribution doesn't create membership status change activity
  https://issues.civicrm.org/jira/browse/CRM-20311

diff --git a/CRM/Contribute/BAO/Contribution.php b/CRM/Contribute/BAO/Contribution.php
index ef9d2f761da1ad54552affa1f7e49cf045aea216..c27b2a4441d74140d7e5cdf1ff0ee167a1b02ebc 100644 (file)
--- a/CRM/Contribute/BAO/Contribution.php
+++ b/CRM/Contribute/BAO/Contribution.php
@@ -1731,7 +1731,7 @@ LEFT JOIN  civicrm_contribution contribution ON ( componentPayment.contribution_
               'source_contact_id' => CRM_Core_Session::singleton()->get('userID'),
               'target_contact_id' => $membership->contact_id,
               'source_record_id' => $membership->id,
-              'activity_type_id' => CRM_Core_PseudoConstant::getKey('CRM_Activity_BAO_Activity', 'activity_type_id', 'Change Membership Status'),
+              'activity_type_id' => 'Change Membership Status',
               'status_id' => 2,
               'priority_id' => 2,
               'activity_date_time' => date('Y-m-d H:i:s'),