crmMailingAB.js - Consolidate 4 TAB_clicked() functions into one gotoTab()

diff --git a/js/angular-crmMailingAB.js b/js/angular-crmMailingAB.js
index ef07cc72aacf6949d02f28a6015167384ddb433b..de685ebd03a37d93bf514da746dc99e0f2293b92 100755 (executable)
--- a/js/angular-crmMailingAB.js
+++ b/js/angular-crmMailingAB.js
@@ -165,27 +165,15 @@
     $scope.tab_val = 0;
     $scope.max_tab = ($scope.sparestuff.isnew == true) ? 0 : 4;
 
-    $scope.campaign_clicked = function () {
-      if ($scope.max_tab >= 0) {
-        $scope.tab_val = 0;
-      }
-    };
-
-    $scope.compose_clicked = function () {
-      if ($scope.max_tab >= 1) {
-        $scope.tab_val = 1;
-      }
-    };
-    $scope.rec_clicked = function () {
-      if ($scope.max_tab >= 2) {
-        $scope.tab_val = 2;
-      }
-    };
-    $scope.preview_clicked = function () {
-      if ($scope.max_tab >= 3) {
-        $scope.tab_val = 3;
+    /**
+     * Example: gotoTab('campaign')
+     */
+    $scope.gotoTab = function(name) {
+      var TABS = {campaign: 0, compose: 1, rec: 2, preview: 3}; // FIXME
+      if ($scope.max_tab >= TABS[name]) {
+        $scope.tab_val = TABS[name];
       }
-    };
+    }
 
     $scope.preview = false;
     $scope.slide_value = 0;

diff --git a/partials/abtesting/main.html b/partials/abtesting/main.html
index e45da6a38f355ad0cc08351b5dd4504e71949497..7259da1f6075b257ad8859cb293c5869dede494b 100755 (executable)
--- a/partials/abtesting/main.html
+++ b/partials/abtesting/main.html
@@ -1,9 +1,9 @@
 <div ui-jq="tabs" class="crmABTestingAllTabs" ui-options="{show: true, hide: true, collapsible: true}">
   <ul>
-    <li><a href="#tabs-1" ng-click="campaign_clicked();">Campaign</a></li>
-    <li><a href="#tabs-2" ng-click="compose_clicked();">Compose</a></li>
-    <li><a href="#tabs-3" ng-click="rec_clicked();">Recipients and Winner Criteria</a></li>
-    <li><a href="#tabs-4" ng-click="preview_clicked();">Preview and Send</a></li>
+    <li><a href="#tabs-1" ng-click="gotoTab('campaign');">Campaign</a></li>
+    <li><a href="#tabs-2" ng-click="gotoTab('compose');">Compose</a></li>
+    <li><a href="#tabs-3" ng-click="gotoTab('rec');">Recipients and Winner Criteria</a></li>
+    <li><a href="#tabs-4" ng-click="gotoTab('preview');">Preview and Send</a></li>
   </ul>
 
   <div id="tabs-1">