CRM-20299 - CiviMail - "Location Type" requirement feels wonky

If you select a "Location Type" and then deselect it, the field changes
to "Automatic". This is the default value (which is acceptable), but the UI
flags it as erroneous.

The "Selection Method" also defaults to "Automatic".  These fields are oddly
a bit different (e.g.  "Automatic" translates to `location_type_id==null`
and `email_selection_method=automatic`), so the fields are a little
different, but this revision brings them closer.

diff --git a/ang/crmMailing/EditRecipOptionsDialogCtrl.html b/ang/crmMailing/EditRecipOptionsDialogCtrl.html
index 53d2c15b88c258d0aba963d754f1847beed4d1cb..4c773b49644da0e7d9adb3d748b7c39039904d2d 100644 (file)
--- a/ang/crmMailing/EditRecipOptionsDialogCtrl.html
+++ b/ang/crmMailing/EditRecipOptionsDialogCtrl.html
@@ -17,9 +17,7 @@
           crm-ui-select="{dropdownAutoWidth : true}"
           name="location_type_id"
           ng-model="model.mailing.location_type_id"
-          required
           >
-
           <option value="">{{ts('Automatic')}}</option>
           <option ng-repeat="locType in model.fields.location_type_id.options"
                   ng-value="locType.key">{{locType.value}}</option>
@@ -32,7 +30,6 @@
           crm-ui-select=""
           name="email_selection_method"
           ng-model="model.mailing.email_selection_method"
-          required
           >
           <option ng-repeat="selMet in model.fields.email_selection_method.options"
                   ng-value="selMet.key">{{selMet.value}}</option>